Page MenuHomeFreeBSD
Differential D51763

bhyve/arm64: Stop assuming the CPU index is MPIDR
ClosedPublic
Actions

Authored by andrew on Wed, Aug 6, 4:20 PM.
Tags
None
Referenced Files
F126535916: D51763.id159963.diff
Wed, Aug 20, 5:11 PM
F126533509: D51763.id.diff
Wed, Aug 20, 4:28 PM
Unknown Object (File)
Wed, Aug 20, 12:20 PM
Unknown Object (File)
Wed, Aug 20, 11:59 AM
Unknown Object (File)
Wed, Aug 20, 11:45 AM
Unknown Object (File)
Wed, Aug 20, 11:36 AM
Unknown Object (File)
Tue, Aug 19, 2:51 PM
Unknown Object (File)
Sat, Aug 16, 4:48 PM
View All 11 Files
Subscribers
bcran
emaste
imp
rgrimes

Details

Reviewers
markj
Group Reviewers
arm64
bhyve
Commits
rG6227d0f81a5e: bhyve/arm64: Stop assuming the CPU index is MPIDR
Summary

We need the MPIDR value in a few places in userspace. Rather than
calculate it ask the kernel to give it to us. This allows us to change
how it is calculated without having to change userspace.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66059
Build 62942: arc lint + arc unit

Event Timeline

andrew created this revision.Wed, Aug 6, 4:20 PM
Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald TranscriptWed, Aug 6, 4:20 PM
andrew requested review of this revision.Wed, Aug 6, 4:20 PM
Harbormaster completed remote builds in B66021: Diff 159877.Wed, Aug 6, 4:20 PM
andrew added a parent revision: D51762: arm64/vmm: Support reading MPIDR_EL1.Wed, Aug 6, 4:20 PM
andrew added a child revision: D51764: arm64/vmm: Support PMU v3p9.
markj added inline comments.Wed, Aug 6, 6:09 PM
usr.sbin/bhyve/aarch64/bhyverun_machdep.c
380

We should check for an error, even if we just assert error == 0.

usr.sbin/bhyve/aarch64/vmexit.c
174–175

This TODO comment can be dropped, no?

andrew updated this revision to Diff 159963.Thu, Aug 7, 12:56 PM

Update based on feedback from @markj
Add a missing header file

Harbormaster completed remote builds in B66059: Diff 159963.Thu, Aug 7, 12:56 PM
andrew updated this revision to Diff 159964.Thu, Aug 7, 2:28 PM

Rebase past 5d56a04d1b99c0187c7799be0d1e93586312bd55

Harbormaster completed remote builds in B66060: Diff 159964.Thu, Aug 7, 2:28 PM
markj accepted this revision as: markj.Thu, Aug 7, 2:47 PM
This revision is now accepted and ready to land.Thu, Aug 7, 2:47 PM
Closed by commit rG6227d0f81a5e: bhyve/arm64: Stop assuming the CPU index is MPIDR (authored by andrew). · Explain WhyThu, Aug 7, 4:42 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG6227d0f81a5e: bhyve/arm64: Stop assuming the CPU index is MPIDR.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
aarch64/
12 lines
22 lines
3 lines
24 lines

Diff 159963

View Options

usr.sbin/bhyve/aarch64/bhyve_machdep.h

Loading...
View Options

usr.sbin/bhyve/aarch64/bhyverun_machdep.c

Loading...
View Options

usr.sbin/bhyve/aarch64/fdt.c

Loading...
View Options

usr.sbin/bhyve/aarch64/vmexit.c

Loading...