Page MenuHomeFreeBSD
Differential D51706

libutil: Add numerous missing MLINKs
ClosedPublic
Actions

Authored by des on Sat, Aug 2, 5:35 PM.
Tags
None
Referenced Files
F126057894: D51706.diff
Thu, Aug 14, 2:21 PM
Unknown Object (File)
Wed, Aug 13, 10:57 PM
Unknown Object (File)
Wed, Aug 13, 9:41 PM
Unknown Object (File)
Wed, Aug 13, 3:43 AM
Unknown Object (File)
Tue, Aug 12, 5:16 PM
Unknown Object (File)
Sun, Aug 10, 4:27 PM
Unknown Object (File)
Sun, Aug 10, 6:10 AM
Unknown Object (File)
Wed, Aug 6, 3:05 AM
View All 15 Files
Subscribers
bcr
imp
ziaee

Details

Reviewers
emaste
olce
imp
Group Reviewers
manpages
Commits
rGa64e03483190: libutil: Add missing MLINKs
rG22afc767869a: libutil: Add missing MLINKs
Summary

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65933
Build 62816: arc lint + arc unit

Event Timeline

des created this revision.Sat, Aug 2, 5:35 PM
Herald added a reviewer: olce. · View Herald TranscriptSat, Aug 2, 5:35 PM
Herald added subscribers: ziaee, imp. · View Herald Transcript
des requested review of this revision.Sat, Aug 2, 5:35 PM
Harbormaster completed remote builds in B65928: Diff 159642.Sat, Aug 2, 5:35 PM
des mentioned this in D51694: libutil: Add symbol versioning.Sat, Aug 2, 5:45 PM
emaste added inline comments.Sat, Aug 2, 9:10 PM
lib/libutil/Makefile
130

duplicate

emaste added a comment.Sat, Aug 2, 9:10 PM

LGTM other than the duplicated line

des marked an inline comment as done.Sat, Aug 2, 9:40 PM
des updated this revision to Diff 159660.Sat, Aug 2, 9:40 PM

dedup

Harbormaster completed remote builds in B65933: Diff 159660.Sat, Aug 2, 9:40 PM
imp accepted this revision.Sun, Aug 3, 6:08 AM

Seems sane now

This revision is now accepted and ready to land.Sun, Aug 3, 6:08 AM
bcr accepted this revision as: manpages.Sun, Aug 3, 2:03 PM
bcr added a subscriber: bcr.

OK from manpages.

emaste accepted this revision.Sun, Aug 3, 2:10 PM
olce accepted this revision.Sun, Aug 3, 5:02 PM

Much more readable like that.

It seems the commit message needs amending though, as almost all mlinks were in fact in the original file. Is some diff missing?

des added a comment.Sun, Aug 3, 5:30 PM
In D51706#1181249, @olce wrote:

It seems the commit message needs amending though, as almost all mlinks were in fact in the original file. Is some diff missing?

Nothing is missing. The patch reformats the Makefile and adds 9 MLINKs which were previously missing.

Closed by commit rG22afc767869a: libutil: Add missing MLINKs (authored by des). · Explain WhySun, Aug 3, 5:33 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG22afc767869a: libutil: Add missing MLINKs.
des added a commit: rGa64e03483190: libutil: Add missing MLINKs.Thu, Aug 14, 4:05 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
179 lines
1 line

Diff 159660

View Options

lib/libutil/Makefile

Loading...
View Options

lib/libutil/pw_util.3

Loading...