Differential D51605

hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)
AcceptedPublic
Actions

Authored by wulf on Mon, Jul 28, 9:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 3, 11:34 AM

	Unknown Object (File)
	Thu, Jul 31, 10:53 AM

	Unknown Object (File)
	Tue, Jul 29, 8:19 AM

	Unknown Object (File)
	Tue, Jul 29, 8:04 AM

	Unknown Object (File)
	Tue, Jul 29, 8:04 AM

	Unknown Object (File)
	Tue, Jul 29, 7:30 AM

	Unknown Object (File)
	Tue, Jul 29, 7:21 AM

Subscribers

Details

Reviewers

emaste
manu
aokblast

Summary

It disables interrupt emulation on poll-driven buses like USB and
forces aquiring of only one USB frame per read(2) operation.
This avoids an FIDO/U2F issue where IN endpoint data received from
the device right before the file handle is closed, gets lost.

PR: 263995
MfC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65816
Build 62699: arc lint + arc unit

Event Timeline

wulf created this revision.Mon, Jul 28, 9:29 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 28, 9:29 PM

wulf requested review of this revision.Mon, Jul 28, 9:29 PM

Harbormaster completed remote builds in B65816: Diff 159369.Mon, Jul 28, 9:29 PM

wulf added a parent revision: D41639: Add u2f(4), a HID driver for FIDO/U2F security keys.Mon, Jul 28, 9:29 PM

aokblast accepted this revision.Fri, Aug 8, 8:07 AM

This revision is now accepted and ready to land.Fri, Aug 8, 8:07 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hid/

1 line

usb/

input/

4 lines

Diff 159369

sys/dev/hid/hidquirk.h

Loading...

sys/dev/usb/input/usbhid.c

Loading...