localedef: Fix a wchar_t comparison
ClosedPublic
Actions

Authored by markj on Mon, Jun 9, 6:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 27, 11:10 PM

	Unknown Object (File)
	Fri, Jun 27, 7:07 PM

	Unknown Object (File)
	Fri, Jun 27, 7:07 PM

	Unknown Object (File)
	Fri, Jun 27, 7:07 PM

	Unknown Object (File)
	Fri, Jun 27, 7:07 PM

	Unknown Object (File)
	Wed, Jun 25, 4:35 PM

	Unknown Object (File)
	Mon, Jun 23, 9:43 PM

	Unknown Object (File)
	Sun, Jun 22, 2:49 PM

View All 16 Files

Subscribers

imp

Details

Reviewers

emaste
kevans
bapt
bnovkov

Commits

rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison

Summary

The intent here is to characterize wide characters which fit in a single
byte. When wchar_t is signed, this comparison is insufficient.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jun 9, 6:29 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 9, 6:29 PM

markj requested review of this revision.Mon, Jun 9, 6:29 PM

Harbormaster completed remote builds in B64726: Diff 156726.Mon, Jun 9, 6:29 PM

markj added a parent revision: D50756: localedef: Use consistent sorting order.Mon, Jun 9, 6:29 PM

markj added a reviewer: bnovkov.Mon, Jun 9, 8:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jun 20, 4:40 PM

Closed by commit rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison.

Revision Contents
Changeset List

Path

Size

usr.bin/

localedef/

collate.c

2 lines

Diff 157380

View Options

usr.bin/localedef/collate.c

localedef: Fix a wchar_t comparisonClosedPublicActions