localedef: Fix a wchar_t comparison
ClosedPublic
Actions

Authored by markj on Jun 9 2025, 6:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 11, 7:48 AM

	Unknown Object (File)
	Wed, Mar 4, 2:54 PM

	Unknown Object (File)
	Wed, Mar 4, 8:31 AM

	Unknown Object (File)
	Tue, Mar 3, 11:16 AM

	Unknown Object (File)
	Mon, Mar 2, 11:38 PM

	Unknown Object (File)
	Feb 7 2026, 11:01 PM

	Unknown Object (File)
	Feb 7 2026, 8:19 PM

	Unknown Object (File)
	Jan 30 2026, 6:32 PM

View All 51 Files

Subscribers

imp

Details

Reviewers

emaste
kevans
bapt
bnovkov

Commits

rG10d14a37206e: localedef: Fix a wchar_t comparison
rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison

Summary

The intent here is to characterize wide characters which fit in a single
byte. When wchar_t is signed, this comparison is insufficient.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 9 2025, 6:29 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2025, 6:29 PM

markj requested review of this revision.Jun 9 2025, 6:29 PM

Harbormaster completed remote builds in B64726: Diff 156726.Jun 9 2025, 6:29 PM

markj added a parent revision: D50756: localedef: Use consistent sorting order.Jun 9 2025, 6:29 PM

markj added a reviewer: bnovkov.Jun 9 2025, 8:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2025, 4:40 PM

Closed by commit rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison.

markj added a commit: rG10d14a37206e: localedef: Fix a wchar_t comparison.Jul 9 2025, 12:45 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

localedef/

collate.c

2 lines

Diff 157380

View Options

usr.bin/localedef/collate.c

localedef: Fix a wchar_t comparisonClosedPublicActions