Differential D50757

localedef: Fix a wchar_t comparison
ClosedPublic
Actions

Authored by markj on Jun 9 2025, 6:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 19, 7:14 AM

	Unknown Object (File)
	Thu, Oct 16, 1:56 PM

	Unknown Object (File)
	Sat, Oct 11, 10:59 AM

	Unknown Object (File)
	Sat, Oct 11, 10:58 AM

	Unknown Object (File)
	Wed, Oct 8, 10:16 AM

	Unknown Object (File)
	Thu, Oct 2, 4:23 AM

	Unknown Object (File)
	Fri, Sep 26, 7:33 PM

	Unknown Object (File)
	Sep 25 2025, 7:44 PM

View All 35 Files

Subscribers

Details

Reviewers

emaste
kevans
bapt
bnovkov

Commits

rG10d14a37206e: localedef: Fix a wchar_t comparison
rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison

Summary

The intent here is to characterize wide characters which fit in a single
byte. When wchar_t is signed, this comparison is insufficient.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64726
Build 61610: arc lint + arc unit

Event Timeline

markj created this revision.Jun 9 2025, 6:29 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2025, 6:29 PM

markj requested review of this revision.Jun 9 2025, 6:29 PM

Harbormaster completed remote builds in B64726: Diff 156726.Jun 9 2025, 6:29 PM

markj added a parent revision: D50756: localedef: Use consistent sorting order.Jun 9 2025, 6:29 PM

markj added a reviewer: bnovkov.Jun 9 2025, 8:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2025, 4:40 PM

Closed by commit rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa37bc4cb8d2c: localedef: Fix a wchar_t comparison.

markj added a commit: rG10d14a37206e: localedef: Fix a wchar_t comparison.Jul 9 2025, 12:45 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

localedef/

2 lines

Diff 156726

usr.bin/localedef/collate.c

Loading...