Page MenuHomeFreeBSD
Differential D50940

gpiobus: gpiobus_acquire_pin: panic on invalid pin
ClosedPublic
Actions

Authored by vexeduxr on Jun 19 2025, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 16, 1:14 AM
Unknown Object (File)
Sat, Jul 5, 4:54 PM
Unknown Object (File)
Sat, Jul 5, 9:52 AM
Unknown Object (File)
Fri, Jul 4, 8:26 PM
Unknown Object (File)
Tue, Jul 1, 5:25 PM
Unknown Object (File)
Fri, Jun 27, 3:35 AM
Unknown Object (File)
Jun 20 2025, 6:47 AM
Unknown Object (File)
Jun 20 2025, 5:55 AM
View All 9 Files
Subscribers
None

Details

Reviewers
imp
wulf
mmel
Commits
rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin
Summary

It is a programming error to call this function with an invalid pin.
Also return proper error value on failure.

Suggested by: mmel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64982
Build 61865: arc lint + arc unit

Event Timeline

vexeduxr requested review of this revision.Jun 19 2025, 2:33 PM
vexeduxr created this revision.
Harbormaster completed remote builds in B64982: Diff 157311.Jun 19 2025, 2:33 PM
vexeduxr added a child revision: D50939: gpiobus: gpiobus_release_pin: convert errors to panic.Jun 19 2025, 2:34 PM
mmel accepted this revision.Jun 19 2025, 2:38 PM
This revision is now accepted and ready to land.Jun 19 2025, 2:38 PM
imp accepted this revision.Thu, Jul 3, 7:57 PM

Go ahead and commit this. I saw the discussion, and this represents what was talked about elsewhere.

Closed by commit rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin (authored by vexeduxr). · Explain WhyFri, Jul 4, 8:26 PM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGed50879c4a95: gpiobus: gpiobus_acquire_pin: panic on invalid pin.

Revision Contents
Changeset List

PathSize
sys/
dev/
gpio/
7 lines

Diff 157311

View Options

sys/dev/gpio/gpiobus.c

Loading...