ix(4): Add support for debug dump for E610 adapters
Needs ReviewPublic
Actions

Authored by Yogesh.Bhosale_intel.com on Jun 19 2025, 9:27 AM.

Details

Reviewers

kbowling
erj

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

This is part 2 of the support for the new Intel Ethernet E610 family of devices.

Intel E610 Ethernet Controller devices feature a debug dump capability that allows you to capture runtime register values directly from the hardware, with assistance from the firmware. These registers are organized into clusters based on their function, enabling targeted debugging. This information is consolidated into a single dump file, facilitating the debugging of complex issues encountered in the field. The debug dump provides a snapshot of the device's current hardware configuration, including switch tables, transmit scheduler tables, and other relevant data. It captures the state of specified clusters and serves as a stateless snapshot of the entire device.

This update introduces ioctl and sysctl support for the debug dump feature.

Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com
Co-developed-by: Krzysztof Galazka krzysztof.galazka@intel.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64977
Build 61860: arc lint + arc unit

Event Timeline

Yogesh.Bhosale_intel.com created this revision.Jun 19 2025, 9:27 AM

Yogesh.Bhosale_intel.com held this revision as a draft.

Owners added a reviewer: Restricted Owners Package.Jun 19 2025, 9:27 AM

Herald added subscribers: ae, imp. · View Herald TranscriptJun 19 2025, 9:27 AM

Harbormaster completed remote builds in B64977: Diff 157303.Jun 19 2025, 9:27 AM

Yogesh.Bhosale_intel.com retitled this revision from This is part 2 of the support for the new Intel Ethernet E610 family of devices. to ix(4): Add support for debug dump for E610 adapters.Jun 19 2025, 9:29 AM

Yogesh.Bhosale_intel.com edited the summary of this revision. (Show Details)

Yogesh.Bhosale_intel.com published this revision for review.Jun 19 2025, 9:42 AM

Yogesh.Bhosale_intel.com mentioned this in D50067: ix/ixv: Add support for new Intel Ethernet E610 family devices.Jun 19 2025, 9:47 AM

@kgalazka Nothing jumping out to me here for feedback on the code. I don't have an E610 so I can't do anything with this.. it looks like this is maybe a support tool where the file is sent to Intel for assistance, but if we can embellish anything as to how an end user might use any of this on their own that would be a worthwhile followup.

erj accepted this revision as: erj.Mon, Aug 4, 2:47 AM

erj added a subscriber: erj.

erj added inline comments.

sys/dev/ixgbe/if_ix.c
1494	Maybe it's because I've only been looking at Intel drivers and what they do with this ioctl, but maybe this check should get moved up into iflib.

kbowling added inline comments.Mon, Aug 4, 5:40 AM

sys/dev/ixgbe/if_ix.c
1494	That's a good point. In the case of non-iflib drivers, this would be the first thing in the registered ioctl handler for a driver interface. So looking at this code I would suggest moving this check up into ixgbe_if_priv_ioctl now, it doesn't seem like anything should let through without the priv_check. And then make a new review with @erj suggestion to do this before calling IFDI_PRIV_IOCTL in iflib.c.. make it contractual that priv_ioctl has been priv_checked and this code can be dropped.