Paths

Table of Contentst

Differential D50870

regulator: don't use internal gpiobus function
ClosedPublic
Actions

Authored by vexeduxr on Jun 16 2025, 7:51 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 1, 8:03 AM

	Unknown Object (File)
	Tue, Oct 28, 10:08 AM

	Unknown Object (File)
	Tue, Oct 28, 4:04 AM

	Unknown Object (File)
	Sun, Oct 26, 9:03 AM

	Unknown Object (File)
	Fri, Oct 24, 9:05 PM

	Unknown Object (File)
	Fri, Oct 24, 7:35 AM

	Unknown Object (File)
	Sat, Oct 18, 2:49 PM

	Unknown Object (File)
	Thu, Oct 16, 1:17 AM

View All 50 Files

Subscribers

Details

Reviewers

imp
wulf
manu
mmel

Commits

rG7f297cdae380: regulator: don't use internal gpiobus function

Summary

gpiobus_acquire_pin is only meant to be used internally by gpiobus. Use
gpio_pin_acquire instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64946
Build 61829: arc lint + arc unit

Event Timeline

vexeduxr created this revision.Jun 16 2025, 7:51 AM

Herald added a subscriber: loos. · View Herald TranscriptJun 16 2025, 7:51 AM

vexeduxr requested review of this revision.Jun 16 2025, 7:51 AM

Harbormaster completed remote builds in B64897: Diff 157091.Jun 16 2025, 7:51 AM

vexeduxr added a child revision: D50871: gpiopps: don't use internal gpiobus function.Jun 16 2025, 7:51 AM

vexeduxr added a parent revision: D50869: gpiobus: add gpio_pin_acquire.Jun 16 2025, 7:53 AM

vexeduxr added a reviewer: manu.

I think that it should be ok but let's wait for @mmel

This revision is now accepted and ready to land.Jun 17 2025, 7:59 AM

Why did you remove the comment? IMHO it is still a bit problematic (or not well defined) to hold the mutex across the GPIO infrastructure call.

I don't really see why it would cause problems. With the current implementation at least.
Thinking about this some more, it's very possible that a future change to gpiobus_acquire_pin or gpio_pin_acquire can break this though...

re-add comment.

This revision now requires review to proceed.Jun 17 2025, 5:09 PM

Harbormaster completed remote builds in B64946: Diff 157203.Jun 17 2025, 5:09 PM

Thanks.
The most problematic variant is GPIO over I2C bus (or other serial bus), where sleepable(SX) locks are required for basic operation. So I just was to be very careful and warn others of the problematic place.

This revision is now accepted and ready to land.Jun 17 2025, 6:21 PM

Looks good, but this is more 'permission to commit' rather than 'the change is good'. I trust the people that reviewed it and didn't see anything insane.

Closed by commit rG7f297cdae380: regulator: don't use internal gpiobus function (authored by vexeduxr). · Explain WhyJul 4 2025, 8:26 PM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rG7f297cdae380: regulator: don't use internal gpiobus function.

Revision Contents
Changeset List

Path

Size

sys/

dev/

regulator/

regulator_fixed.c

8 lines

Diff 157203

sys/dev/regulator/regulator_fixed.c

Loading...