Differential D50898

tcp: unlock before syncookie_expand()
ClosedPublic
Actions

Authored by glebius on Jun 17 2025, 4:16 AM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG1b72d275eef4: tcp: unlock before syncookie_expand()
rG0809d26de24d: tcp: unlock before syncookie_expand()

Summary

The function doesn't need a lock on sch. It uses the pointer as value for
the SipHash calculation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64931
Build 61814: arc lint + arc unit

Event Timeline

glebius created this revision.Jun 17 2025, 4:16 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptJun 17 2025, 4:16 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Jun 17 2025, 4:16 AM

glebius added a parent revision: D50897: tcp: increase tcps_sc_recvcookie only in the syncache_expand().

Harbormaster completed remote builds in B64931: Diff 157160.Jun 17 2025, 4:16 AM

glebius added a child revision: D50899: tcp: count two previously ignored kinds of syncookie failures.Jun 17 2025, 4:16 AM

tuexen accepted this revision.Jun 17 2025, 6:45 AM

This revision is now accepted and ready to land.Jun 17 2025, 6:45 AM

Closed by commit rG0809d26de24d: tcp: unlock before syncookie_expand() (authored by glebius). · Explain WhyJun 17 2025, 3:51 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG0809d26de24d: tcp: unlock before syncookie_expand().

tuexen added a commit: rG1b72d275eef4: tcp: unlock before syncookie_expand().Sep 9 2025, 6:07 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

7 lines

Diff 157160

View Options

sys/netinet/tcp_syncache.c

tcp: unlock before syncookie_expand()ClosedPublicActions