libusb: add option
Needs ReviewPublic
Actions

Authored by aokblast on Thu, Jun 12, 4:08 PM.

Details

Reviewers

bapt

Group Reviewers

USB

Summary

Implement libusb_set_option for API compatibility of libusb upstream
The implementation status of each option is as following:

LIBUSB_OPTION_LOG_LEVEL: just like libusb_set_debug
LIBUSB_OPTION_LOG_CB: add callback support for DPRINTF
LIBUSB_OPTION_NO_DEVICE_DISCOVERY: disable initialization of devd and
netlink when register. Also, create no thread when registration of
callback happens.
LIBUSB_OPTION_USE_USBDK: no needed as USBDK is for Windows

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64893
Build 61776: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, Jun 12, 4:08 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 12, 4:08 PM

aokblast requested review of this revision.Thu, Jun 12, 4:08 PM

Harbormaster completed remote builds in B64820: Diff 156920.Thu, Jun 12, 4:08 PM

The change about DEBUG_LEVEL to LOG_LEVEL is required to allow set_debug and debug callback works. So add that patch as a parent.

Fix indent

Harbormaster completed remote builds in B64827: Diff 156935.Thu, Jun 12, 7:56 PM

aokblast mentioned this in D50680: libusb: replace DEBUG_LEVEL with LOG_LEVEL.Thu, Jun 12, 10:03 PM

kevans added a subscriber: kevans.Thu, Jun 12, 10:17 PM

kevans added inline comments.

lib/libusb/libusb10.c
246	`log_level` seems to be unused in this final version, can it be removed?
1812	style(9) dictates explicit comparison against `NULL` here
lib/libusb/libusb10_hotplug.c
382	Is there some implication here for `no_discovery`? Should this be reachable at all if it's set?

aokblast added inline comments.Fri, Jun 13, 2:38 PM

lib/libusb/libusb10_hotplug.c
382	The no_discovery in upstream libusb is utilized when init the context. It will not start any hotplug scan thread if this option is true on the upstream libusb. That means this option is useless after libusb_init is called. However, our implementation on the hotplug scan thread starts when the hotplug register is called instead of the libusb_init. I think the time point of no_discovery on upstream libusb is tighter because after init it will not work. So our implementation to do check on hotplug handler won't break any usecase of this option as it is expected to be set before init the context and actually hotplug register should be called after init.