lualoader: allow graphical bits to be disabled with loader_gfx
ClosedPublic
Actions

Authored by kevans on Jun 5 2025, 9:42 PM.

Details

Reviewers

imp
tsoome
manu

Group Reviewers

manpages

Commits

rGbef6d85b6de5: lualoader: allow graphical bits to be disabled with loader_gfx

Summary

Some people prefer the old ASCII art look and it's good to have a way
to confirm that the fallbacks still work right on systems that have a
functional framebuffer available. Add a loader_gfx loader.conf(5)
variable to disable the eager use of graphics for these use-cases.

While we're here, clean up the style in the area a little bit; the early
porting that I did to lualoader did a lot of redundant ~= nil that has
carried over into some of the later work. We can drop some of that, and
also re-organize some of these variables to improve readability.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64666
Build 61550: arc lint + arc unit

Event Timeline

kevans created this revision.Jun 5 2025, 9:42 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 5 2025, 9:42 PM

Herald added subscribers: ziaee, dab. · View Herald Transcript

kevans requested review of this revision.Jun 5 2025, 9:42 PM

Harbormaster completed remote builds in B64665: Diff 156593.Jun 5 2025, 9:42 PM

Rename to loader_gfx, cover the brand and menu frame as well

Harbormaster completed remote builds in B64666: Diff 156595.Jun 5 2025, 10:07 PM

kevans retitled this revision from lualoader: allow graphical logos to be disabled with loader_logo_gfx to lualoader: allow graphical bits to be disabled with loader_gfx.Jun 5 2025, 10:08 PM

kevans edited the summary of this revision. (Show Details)

imp accepted this revision.Jun 5 2025, 10:30 PM

This revision is now accepted and ready to land.Jun 5 2025, 10:30 PM

{F119160589}

Tested by: ziaee

{F119160774}

Although the offset of the orb is a bit changed due to centering it for the graphical logo a few months ago.

ziaee accepted this revision as: manpages.Jun 5 2025, 10:34 PM

ziaee added a reviewer: manpages.

In D50706#1157524, @ziaee wrote:

{F119160589}

Tested by: ziaee

{F119160774}

Although the offset of the orb is a bit changed due to centering it for the graphical logo a few months ago.

18:13 <@kevans91> the graphical bits in gfx-*.lua should've been a gfx { image, shift, height } table or 
                  something
[...]
18:22 <@kevans91> maybe if i get bored on a flight next week i'll play with it

manu accepted this revision.Jun 6 2025, 5:51 AM

Closed by commit rGbef6d85b6de5: lualoader: allow graphical bits to be disabled with loader_gfx (authored by kevans). · Explain WhyJun 6 2025, 2:45 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGbef6d85b6de5: lualoader: allow graphical bits to be disabled with loader_gfx.