Page MenuHomeFreeBSD

lualoader: allow graphical bits to be disabled with loader_gfx
ClosedPublic

Authored by kevans on Jun 5 2025, 9:42 PM.
Tags
None
Referenced Files
F131944774: D50706.id.diff
Sun, Oct 12, 9:53 AM
Unknown Object (File)
Mon, Sep 29, 3:23 PM
Unknown Object (File)
Mon, Sep 22, 2:02 PM
Unknown Object (File)
Sat, Sep 20, 5:22 AM
Unknown Object (File)
Fri, Sep 19, 11:55 PM
Unknown Object (File)
Fri, Sep 19, 5:24 AM
Unknown Object (File)
Sat, Sep 13, 10:50 PM
Unknown Object (File)
Aug 26 2025, 7:47 AM
Subscribers

Details

Summary

Some people prefer the old ASCII art look and it's good to have a way
to confirm that the fallbacks still work right on systems that have a
functional framebuffer available. Add a loader_gfx loader.conf(5)
variable to disable the eager use of graphics for these use-cases.

While we're here, clean up the style in the area a little bit; the early
porting that I did to lualoader did a lot of redundant ~= nil that has
carried over into some of the later work. We can drop some of that, and
also re-organize some of these variables to improve readability.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64665
Build 61549: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Jun 5 2025, 9:42 PM

Rename to loader_gfx, cover the brand and menu frame as well

kevans retitled this revision from lualoader: allow graphical logos to be disabled with loader_logo_gfx to lualoader: allow graphical bits to be disabled with loader_gfx.Jun 5 2025, 10:08 PM
kevans edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 5 2025, 10:30 PM

{F119160589}

Tested by: ziaee

{F119160774}

Although the offset of the orb is a bit changed due to centering it for the graphical logo a few months ago.

ziaee added a reviewer: manpages.

{F119160589}

Tested by: ziaee

{F119160774}

Although the offset of the orb is a bit changed due to centering it for the graphical logo a few months ago.

18:13 <@kevans91> the graphical bits in gfx-*.lua should've been a gfx { image, shift, height } table or 
                  something
[...]
18:22 <@kevans91> maybe if i get bored on a flight next week i'll play with it