Page MenuHomeFreeBSD

net80211: create ieee80211_vap_printf() / ieee80211_ic_printf() for printing
ClosedPublic

Authored by adrian on Mon, Jun 2, 2:11 AM.
Referenced Files
Unknown Object (File)
Tue, Jun 10, 2:20 PM
Unknown Object (File)
Mon, Jun 9, 2:45 PM
Unknown Object (File)
Sun, Jun 8, 11:53 PM
Unknown Object (File)
Sun, Jun 8, 9:31 PM
Unknown Object (File)
Fri, Jun 6, 6:55 PM
Unknown Object (File)
Fri, Jun 6, 5:38 PM
Unknown Object (File)
Thu, Jun 5, 11:59 PM
Unknown Object (File)
Thu, Jun 5, 6:45 PM

Details

Summary

Not all OSes support if_printf(), printf(), etc, so start migrating
the printf / log routines into net80211 routines that are implemented
in ieee80211_freebsd.c .

Migrate ic_printf() to ieee80211_ic_printf() via a macro for testing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian requested review of this revision.Mon, Jun 2, 2:11 AM

So i was thinking if we can start using ieee80211 for standards things and use a net80211 prefix for our own stuff (at least for anything new or we change)?

I am still torn on the vlog(INFO; I know if_log went there but we have a lot of things which will not show up on console that way anymore; I already know from the if_log bit and that's a bit annoying; also re-ordering and overlappig...

Almost calls in the future for a version to take a debug bool or foo_debug or something what the things can come out appropriately and the others to go at vprintf; I am just thinking loudly...

In D50642#1156201, @bz wrote:

So i was thinking if we can start using ieee80211 for standards things and use a net80211 prefix for our own stuff (at least for anything new or we change)?

I think that's a good idea. I'll go update the diff stack.

I am still torn on the vlog(INFO; I know if_log went there but we have a lot of things which will not show up on console that way anymore; I already know from the if_log bit and that's a bit annoying; also re-ordering and overlappig...

Almost calls in the future for a version to take a debug bool or foo_debug or something what the things can come out appropriately and the others to go at vprintf; I am just thinking loudly...

It would be nice to have an if_vprintf(), device_vprintf(), etc so i didn't have to do these hijinx but we don't, hence why I'm currently rolling my own.
And yeah, once we've migrated all the code over, we can churn on how we want it presented/logged/traced/etc pretty mechanically.

bz requested changes to this revision.Tue, Jun 3, 10:02 PM
bz added inline comments.
sys/net80211/ieee80211_freebsd.c
1371

This will allow subr_printf to intermix multiple log messages. But let's get these in and then improve them.

This revision now requires changes to proceed.Tue, Jun 3, 10:02 PM
This revision is now accepted and ready to land.Tue, Jun 3, 10:02 PM