Page MenuHomeFreeBSD
Differential D50461

icmp6: zero out pad space
ClosedPublic
Actions

Authored by kp on Thu, May 22, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 13, 11:35 AM
Unknown Object (File)
Wed, Jun 11, 1:21 PM
Unknown Object (File)
Thu, Jun 5, 6:52 AM
Unknown Object (File)
Wed, Jun 4, 8:13 PM
Unknown Object (File)
Tue, Jun 3, 1:41 AM
Unknown Object (File)
Fri, May 30, 12:59 PM
Unknown Object (File)
Sat, May 24, 8:00 AM
Unknown Object (File)
Sat, May 24, 12:14 AM
View All 12 Files
Subscribers
ae
glebius
imp
melifaro
zlei

Details

Reviewers
zlei
Group Reviewers
network
pfsense
Commits
rG0a16f62701f1: icmp6: zero out pad space
Summary

In icmp6_redirect_output() we potentially add padding, but failed to clear this
memory. This triggered a KMSAN panic during the sys/netinet/carp:unicast_v6
test.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64348
Build 61232: arc lint + arc unit

Event Timeline

kp created this revision.Thu, May 22, 12:39 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptThu, May 22, 12:39 PM
kp requested review of this revision.Thu, May 22, 12:39 PM
Harbormaster completed remote builds in B64348: Diff 155858.Thu, May 22, 12:39 PM
zlei accepted this revision as: zlei.Thu, May 22, 2:24 PM
zlei added a subscriber: zlei.

Looks good to me.

This revision is now accepted and ready to land.Thu, May 22, 2:24 PM
Closed by commit rG0a16f62701f1: icmp6: zero out pad space (authored by kp). · Explain WhyFri, May 23, 1:07 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG0a16f62701f1: icmp6: zero out pad space.

Revision Contents
Changeset List

PathSize
sys/
netinet6/
1 line

Diff 155858

View Options

sys/netinet6/icmp6.c

Loading...