qat.4: Cleanup
ClosedPublic
Actions

Authored by ziaee on Fri, May 16, 5:23 PM.

Details

Reviewers

ivy
mhorne
carlavilla
adrian
markj

Group Reviewers

manpages

Commits

rG86b04d37f012: qat.4: Cleanup
rG802edf230793: qat.4: Cleanup
rGc1d9b2c9b03c: qat.4: Cleanup

Summary

+ copyright symbols do not belong in Nd's (apropos results)
+ move hardware to HARDWARE for inclusion in the hw release notes
+ lines which say nothing removed
+ links moved to see also
+ spacing and markup corrections

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64224
Build 61108: arc lint + arc unit

Event Timeline

ziaee created this revision.Fri, May 16, 5:23 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, May 16, 5:23 PM

ziaee requested review of this revision.Fri, May 16, 5:23 PM

Harbormaster completed remote builds in B64222: Diff 155571.Fri, May 16, 5:23 PM

Markj asked to be cc on all qat changes.

markj added inline comments.Fri, May 16, 5:58 PM

share/man/man4/qat.4
44
114	This is not the same uio.
182	I don't understand the reference to 13.5: the original qat driver was indeed in 13.0.

Overall it is a clear improvement.

share/man/man4/qat.4
41–43	These two statements are more closely related. Alternatively, each can be its own paragraph.
122	You might bump the width here. Currently every description in the list is pushed to the second line, so this would help visually.

address markj feedback, thank you so much!

Harbormaster completed remote builds in B64224: Diff 155573.Fri, May 16, 6:26 PM

address mhorne's feedback; improve sysctls so that the complete sysctl
is more easily searchable with apropos.

Harbormaster completed remote builds in B64225: Diff 155574.Fri, May 16, 6:35 PM

ziaee marked an inline comment as done.Fri, May 16, 6:36 PM

ziaee added inline comments.

share/man/man4/qat.4
41–43	Fixed. I think they should really be rewritten to one statement. I think also the description could use some more detail, like, qat supports zfs gzip compression, and readers probably want to know that.
122	I wasn't sure what to do with it because I think that these sysctls actually need the prefix so they're more easily searchable with apropos.
182	Fixed. Sorry, the oldest commit I found said it was in 13.5 with `git branch --contains`.