Page MenuHomeFreeBSD
Differential D50337

sound: Call PCM_RELEASE() if pcm_addchan() fails
ClosedPublic
Actions

Authored by christos on May 13 2025, 8:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 9, 9:15 AM
Unknown Object (File)
Thu, Jul 9, 9:14 AM
Unknown Object (File)
Wed, Jul 8, 4:03 AM
Unknown Object (File)
Mon, Jul 6, 1:24 PM
Unknown Object (File)
Sun, Jul 5, 7:32 AM
Unknown Object (File)
Jun 18 2026, 1:59 PM
Unknown Object (File)
May 23 2026, 2:24 AM
Unknown Object (File)
May 23 2026, 2:24 AM
View All 86 Files
Subscribers
imp

Details

Reviewers
markj
emaste
jhibbits
Commits
rGaff92a9f3c6c: sound: Call PCM_RELEASE() if pcm_addchan() fails
rG3de66f369c1e: sound: Call PCM_RELEASE() if pcm_addchan() fails
rGdbfe79bbe5d5: sound: Call PCM_RELEASE() if pcm_addchan() fails
Summary

Fixes: fd906e47b18f ("sound: Simplify locking during device creation")
Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64149
Build 61033: arc lint + arc unit

Event Timeline

christos created this revision.May 13 2025, 8:24 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 13 2025, 8:24 PM
christos requested review of this revision.May 13 2025, 8:24 PM
Harbormaster completed remote builds in B64149: Diff 155413.May 13 2025, 8:24 PM
christos mentioned this in D48482: sound: Simplify locking during device creation.May 13 2025, 8:25 PM

@markj If this fixes the issue mentioned in D48482, should we MFC it to releng/14.3 as well?

markj accepted this revision.May 13 2025, 9:54 PM
In D50337#1148520, @christos wrote:

@markj If this fixes the issue mentioned in D48482, should we MFC it to releng/14.3 as well?

Yes, definitely.

This revision is now accepted and ready to land.May 13 2025, 9:54 PM
christos added a comment.May 13 2025, 10:03 PM
In D50337#1148551, @markj wrote:
In D50337#1148520, @christos wrote:

@markj If this fixes the issue mentioned in D48482, should we MFC it to releng/14.3 as well?

Yes, definitely.

Alright. Can I do it directly or do I need to get formal approval from re@?

Closed by commit rGdbfe79bbe5d5: sound: Call PCM_RELEASE() if pcm_addchan() fails (authored by christos). · Explain WhyMay 13 2025, 10:03 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGdbfe79bbe5d5: sound: Call PCM_RELEASE() if pcm_addchan() fails.
markj added a comment.May 13 2025, 10:05 PM
In D50337#1148554, @christos wrote:
In D50337#1148551, @markj wrote:
In D50337#1148520, @christos wrote:

@markj If this fixes the issue mentioned in D48482, should we MFC it to releng/14.3 as well?

Yes, definitely.

Alright. Can I do it directly or do I need to get formal approval from re@?

You need to MFC to stable/14 first, then request approval from re@: https://wiki.freebsd.org/Releng/ChangeRequestGuidelines

christos added a commit: rG3de66f369c1e: sound: Call PCM_RELEASE() if pcm_addchan() fails.May 14 2025, 11:45 AM
christos added a commit: rGaff92a9f3c6c: sound: Call PCM_RELEASE() if pcm_addchan() fails.May 14 2025, 2:24 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
6 lines

Diff 155413

View Options

sys/dev/sound/pcm/sound.c

Loading...