This matches the style of the component selection dialog for traditional
tarball-based installations. The only difference is that there is
currently no ports component offered when using pkgbase.
Sponsored by: The FreeBSD Foundation
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 63934 Build 60818: arc lint + arc unit
Event Timeline
Comment Actions
Extract component selection to a separate function
After a nights sleep, I realized I had written an excessively long function
| usr.sbin/bsdinstall/scripts/pkgbase.in | ||
|---|---|---|
| 44 | Can we add a comment with a brief description for each of these functions? | |
| 76 | These should probably be "Kernel Debug Data" or so. You've followed what the dist sets do today so there's an argument for consistency, but I think that's a bug to be fixed in the dist sets (and can pick that up). Kernel (Debugging) could suggest this is a debugging kernel, an alternative to a Kernel (Standard). I've submitted D50254 to change this for dist sets. | |
| usr.sbin/bsdinstall/scripts/pkgbase.in | ||
|---|---|---|
| 76 | Indeed, this is a good opportunity to improve this terminology. I left a comment with a minor bikeshed on https://reviews.freebsd.org/D50254 and will copy whatever terminology gets decided upon there for this patch. | |