bsdinstall: add pkgbase component selection dialog

[ifreund_freebsdfoundation.org]

Summary

This matches the style of the component selection dialog for traditional
tarball-based installations. The only difference is that there is
currently no ports component offered when using pkgbase.

Sponsored by: The FreeBSD Foundation

[ifreund_freebsdfoundation.org]

Extract component selection to a separate function

After a nights sleep, I realized I had written an excessively long function

[emaste]

usr.sbin/bsdinstall/scripts/pkgbase.in

44–146

Can we add a comment with a brief description for each of these functions?

76

These should probably be "Kernel Debug Data" or so. You've followed what the dist sets do today so there's an argument for consistency, but I think that's a bug to be fixed in the dist sets (and can pick that up). Kernel (Debugging) could suggest this is a debugging kernel, an alternative to a Kernel (Standard).

I've submitted D50254 to change this for dist sets.

[ifreund_freebsdfoundation.org]

usr.sbin/bsdinstall/scripts/pkgbase.in

76

Indeed, this is a good opportunity to improve this terminology. I left a comment with a minor bikeshed on https://reviews.freebsd.org/D50254 and will copy whatever terminology gets decided upon there for this patch.

[ifreund_freebsdfoundation.org]

Add more comments, adjust wording to match D50254

[ifreund_freebsdfoundation.org]

Hide components with no available packages in the menu