Differential D50071

igmp: apply net.inet.igmp.default_version to existing interfaces
ClosedPublic
Actions

Authored by kp on Apr 29 2025, 2:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 22, 11:08 AM

	Unknown Object (File)
	Sat, Nov 22, 11:05 AM

	Unknown Object (File)
	Sat, Nov 22, 10:57 AM

	Unknown Object (File)
	Sat, Nov 22, 10:57 AM

	Unknown Object (File)
	Sat, Nov 15, 2:35 AM

	Unknown Object (File)
	Sat, Nov 15, 1:05 AM

	Unknown Object (File)
	Fri, Nov 14, 10:40 AM

	Unknown Object (File)
	Fri, Nov 14, 4:18 AM

View All 46 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rGd2c2d6d6b09e: igmp: apply net.inet.igmp.default_version to existing interfaces

Summary

IGMP requires hosts to use the lowest version they have seen on the network.
When net.inet.igmp.default_version is changed, we do not change IGMP
version used by interface even if the interface use an higher version than
V_igmp_default_version. So we could send IGMPv3 even if the user has requested
IGMPv2 or IGMPv1 via the sysctl.

Change IGMP version for each interface when V_igmp_default_version is smaller
than the version used by the interface.

Pull Request: https://github.com/freebsd/freebsd-src/pull/1615

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63777
Build 60661: arc lint + arc unit

Event Timeline

kp created this revision.Apr 29 2025, 2:29 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptApr 29 2025, 2:29 PM

kp requested review of this revision.Apr 29 2025, 2:29 PM

kp added a child revision: D50072: netinet tests: ensure we send IGMPv2 messages if net.inet.igmp.default_version=2.

Harbormaster completed remote builds in B63777: Diff 154474.Apr 29 2025, 2:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2025, 8:24 AM

Closed by commit rGd2c2d6d6b09e: igmp: apply net.inet.igmp.default_version to existing interfaces (authored by Olivier BLANC <etihwo@outlook.com>, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGd2c2d6d6b09e: igmp: apply net.inet.igmp.default_version to existing interfaces.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

33 lines

Diff 154474

sys/netinet/igmp.c

Loading...