This is a calque of the NetBSD function of the same name.
MFC after: never
Relontes: yes
Sponsored by: Klara, Inc.
Details
Details
- Reviewers
kevans - Group Reviewers
Klara - Commits
- rG873420ca1e6e: libc: Add getenv_r() function.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 63668 Build 60552: arc lint + arc unit
Event Timeline
Comment Actions
If you're up for it, adding _FORTIFY_SOURCE support for this would be nearly trivial. The __ssp_redirect pattern for arc4random_buf in include/ssp/stdlib.h can be copied for this (the __buf and __len names are significant and used in the implementation for size-checking, other names are fair game) and tests added easily by copying arc4random_buf again in lib/libc/tests/secure/generate-fortify-tests.lua (regeneration requires devel/lua-luacheck for make generate-tests).
| lib/libc/stdlib/getenv.c | ||
|---|---|---|
| 475 | Wouldn't it be more useful to somehow return the actual size of the variable? Userspace effectively has to guess and just double the size until getenv_r() succeeds. | |
| lib/libc/stdlib/getenv.c | ||
|---|---|---|
| 475 | Worse, we copy to the buffer and return an error.... | |
| lib/libc/stdlib/getenv.c | ||
|---|---|---|
| 475 | I'm afraid there's 20 years of precedent for this. I'm loath to break that, even if we're the first outside NetBSD to adopt it. | |