Page MenuHomeFreeBSD
Differential D49952

Search for mntopts.h globally, not locally
ClosedPublic
Actions

Authored by brooks on Apr 21 2025, 10:18 PM.
Tags
None
Referenced Files
F168994704: D49952.id154125.diff
Mon, Aug 31, 2:18 AM
Unknown Object (File)
Sat, Aug 29, 8:55 PM
Unknown Object (File)
Tue, Aug 25, 5:10 AM
Unknown Object (File)
Sat, Aug 22, 9:56 PM
Unknown Object (File)
Mon, Aug 17, 3:05 AM
Unknown Object (File)
Thu, Aug 13, 3:09 AM
Unknown Object (File)
Wed, Aug 12, 11:25 PM
Unknown Object (File)
Wed, Aug 12, 7:04 PM
View All Files
Subscribers
asomers
dim
patmaddox

Details

Reviewers
mckusick
jrtc27
imp
olce
emaste
dim
Commits
rGa123502ef781: Search for mntopts.h globally, not locally
Summary

Change the include directives to use <mntopts.h> instead of "mntopts.h"
now that it's installed by libutil (the latter option was dubious
regardless since a -I${SRCTOP}/sbin/mount was required anyway).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 63621
Build 60505: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 21 2025, 10:18 PM
Herald added a reviewer: olce. · View Herald TranscriptApr 21 2025, 10:18 PM
Herald added a subscriber: asomers. · View Herald Transcript
brooks requested review of this revision.Apr 21 2025, 10:18 PM
Harbormaster completed remote builds in B63621: Diff 154057.Apr 21 2025, 10:18 PM
brooks added a parent revision: D49951: Move mntopts(3) suppport into libutil.Apr 21 2025, 10:18 PM
imp accepted this revision.Apr 21 2025, 10:30 PM
This revision is now accepted and ready to land.Apr 21 2025, 10:30 PM
brooks mentioned this in D49958: Move mount related functions into libmount.Apr 22 2025, 3:47 PM
emaste accepted this revision.Apr 22 2025, 4:42 PM
dim accepted this revision.Apr 22 2025, 5:28 PM
dim added a subscriber: dim.

LGTM, as long as there are include guards in mntopts.h :)

patmaddox added a subscriber: patmaddox.Apr 22 2025, 6:05 PM
olce accepted this revision.Apr 22 2025, 7:29 PM
Closed by commit rGa123502ef781: Search for mntopts.h globally, not locally (authored by brooks). · Explain WhyApr 22 2025, 9:52 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGa123502ef781: Search for mntopts.h globally, not locally.

Revision Contents
Changeset List

PathSize
contrib/
smbfs/
mount_smbfs/
3 lines
lib/
libutil/
3 lines
sbin/
init/
2 lines
mount/
2 lines
2 lines
mount_cd9660/
3 lines
mount_fusefs/
3 lines
mount_msdosfs/
3 lines
mount_nfs/
2 lines
mount_nullfs/
3 lines
mount_udf/
3 lines
mount_unionfs/
3 lines
tests/
sys/
fs/
fusefs/
3 lines
3 lines
2 lines
usr.sbin/
autofs/
2 lines
mountd/
2 lines

Diff 154057

View Options

contrib/smbfs/mount_smbfs/mount_smbfs.c

Loading...
View Options

lib/libutil/getmntopts.c

Loading...
View Options

sbin/init/init.c

Loading...
View Options

sbin/mount/mount.c

Loading...
View Options

sbin/mount/mount_fs.c

Loading...
View Options

sbin/mount_cd9660/mount_cd9660.c

Loading...
View Options

sbin/mount_fusefs/mount_fusefs.c

Loading...
View Options

sbin/mount_msdosfs/mount_msdosfs.c

Loading...
View Options

sbin/mount_nfs/mount_nfs.c

Loading...
View Options

sbin/mount_nullfs/mount_nullfs.c

Loading...
View Options

sbin/mount_udf/mount_udf.c

Loading...
View Options

sbin/mount_unionfs/mount_unionfs.c

Loading...
View Options

tests/sys/fs/fusefs/fallocate.cc

Loading...
View Options

tests/sys/fs/fusefs/mockfs.cc

Loading...
View Options

tests/sys/fs/fusefs/mount.cc

Loading...
View Options

usr.sbin/autofs/automount.c

Loading...
View Options

usr.sbin/mountd/mountd.c

Loading...