Differential D49774

sys: protect the kernel build from accidental _FORTIFY_SOURCE
ClosedPublic
Actions

Authored by kevans on Apr 11 2025, 3:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 16, 8:37 PM

	Unknown Object (File)
	Wed, Sep 16, 3:49 PM

	Unknown Object (File)
	Wed, Sep 16, 8:50 AM

	Unknown Object (File)
	Fri, Sep 11, 11:19 PM

	Unknown Object (File)
	Aug 29 2026, 5:33 PM

	Unknown Object (File)
	Aug 28 2026, 1:50 PM

	Unknown Object (File)
	Aug 12 2026, 8:10 PM

	Unknown Object (File)
	Aug 10 2026, 9:23 AM

View All 83 Files

Subscribers

Details

Reviewers

markj
emaste
imp

Commits

rG858b5e424816: sys: protect the kernel build from accidental _FORTIFY_SOURCE

Summary

Fortification is a userland feature, thus the flag makes no sense in a
kernel context at the moment. Move the relevant includes that aren't
already in a !_KERNEL block under a !_KERNEL condition to avoid breaking
kernel/kmod builds that are catching a stray -D_FORTIFY_SOURCE in their
CFLAGS.

PR: 286010

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63447
Build 60331: arc lint + arc unit

Event Timeline

kevans created this revision.Apr 11 2025, 3:33 AM

Herald added subscribers: glebius, imp. · View Herald TranscriptApr 11 2025, 3:33 AM

kevans requested review of this revision.Apr 11 2025, 3:33 AM

Harbormaster completed remote builds in B63447: Diff 153493.Apr 11 2025, 3:33 AM

patmaddox added a subscriber: patmaddox.Apr 11 2025, 3:39 AM

jlduran added a subscriber: jlduran.Apr 11 2025, 12:04 PM

markj accepted this revision.Apr 11 2025, 1:33 PM

markj added inline comments.

sys/sys/poll.h
112	We're already in a ifndef _KERNEL block here.

This revision is now accepted and ready to land.Apr 11 2025, 1:33 PM

kevans added inline comments.Apr 11 2025, 2:10 PM

sys/sys/poll.h
112	Whoops, missed that; will remove, thanks.

emaste accepted this revision.Apr 11 2025, 2:19 PM

imp accepted this revision.Apr 11 2025, 2:22 PM

imp added inline comments.

sys/sys/poll.h
112	my approval is conditional on dropping this one change.

Closed by commit rG858b5e424816: sys: protect the kernel build from accidental _FORTIFY_SOURCE (authored by kevans). · Explain WhyApr 12 2025, 1:54 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG858b5e424816: sys: protect the kernel build from accidental _FORTIFY_SOURCE.

Revision Contents
Changeset List

Path

Size

sys/

sys/

2 lines

10 lines

2 lines

4 lines

Diff 153493

sys/sys/poll.h

Loading...

sys/sys/random.h

Loading...

sys/sys/select.h

Loading...

sys/sys/socket.h

Loading...