Differential D49648

ctld: Require a mask if / is specified in an initiator portal
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 9, 11:45 AM

	Unknown Object (File)
	Apr 30 2026, 8:35 PM

	Unknown Object (File)
	Apr 27 2026, 3:31 PM

	Unknown Object (File)
	Apr 27 2026, 5:26 AM

	Unknown Object (File)
	Apr 26 2026, 3:46 PM

	Unknown Object (File)
	Apr 19 2026, 12:23 PM

	Unknown Object (File)
	Apr 19 2026, 10:59 AM

	Unknown Object (File)
	Apr 19 2026, 7:38 AM

View All 72 Files

Subscribers

Details

Reviewers

Commits

rG8c211a00d3b4: ctld: Require a mask if / is specified in an initiator portal
rG4449cf28a315: ctld: Require a mask if / is specified in an initiator portal

Summary

If the / separator in a portal string is the last character in the
string, treat the portal as invalid.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63293
Build 60177: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 2 2025, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:05 PM

jhb requested review of this revision.Apr 2 2025, 8:05 PM

Harbormaster completed remote builds in B63293: Diff 153047.Apr 2 2025, 8:05 PM

jhb added a parent revision: D49647: ctld: Tighten parsing of IPv6 addresses for initiator-portal.Apr 2 2025, 8:05 PM

jhb added a child revision: D49649: ctld: Remove dead logging code.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rG4449cf28a315: ctld: Require a mask if / is specified in an initiator portal (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4449cf28a315: ctld: Require a mask if / is specified in an initiator portal.

jhb added a commit: rG8c211a00d3b4: ctld: Require a mask if / is specified in an initiator portal.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

2 lines

Diff 153047

usr.sbin/ctld/ctld.cc

Loading...