ctld: Tighten parsing of IPv6 addresses for initiator-portal
ClosedPublic
Actions

Authored by jhb on Apr 2 2025, 8:05 PM.

Details

Reviewers

Commits

rG541c6c9d75c1: ctld: Tighten parsing of IPv6 addresses for initiator-portal
rGf3eb1514ce44: ctld: Tighten parsing of IPv6 addresses for initiator-portal

Summary

If an address starts with a [ character, require that it ends with a ]
character. Also, if an address starts with a [ character, assume it
is an IPv6 address.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63292
Build 60176: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 2 2025, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2025, 8:05 PM

jhb requested review of this revision.Apr 2 2025, 8:05 PM

Harbormaster completed remote builds in B63292: Diff 153046.Apr 2 2025, 8:05 PM

jhb added a parent revision: D49646: ctld: Drop commented-out code to print the configuration.Apr 2 2025, 8:05 PM

jhb added a child revision: D49648: ctld: Require a mask if / is specified in an initiator portal.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2025, 2:04 PM

Closed by commit rGf3eb1514ce44: ctld: Tighten parsing of IPv6 addresses for initiator-portal (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf3eb1514ce44: ctld: Tighten parsing of IPv6 addresses for initiator-portal.

jhb added a commit: rG541c6c9d75c1: ctld: Tighten parsing of IPv6 addresses for initiator-portal.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.cc

15 lines

Diff 153046

View Options

ctld: Tighten parsing of IPv6 addresses for initiator-portalClosedPublicActions