Make it easier for the compiler to inline this in the many cases where the 'af'
is known at compile time.
Sponsored by: Rubicon Communications, LLC ("Netgate")
Details
Details
- Reviewers
glebius markj - Group Reviewers
network - Commits
- rGe7995c99f1e4: pf: inline pf_addrcpy()
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Sidenote: how far are we from not installing pfvar.h into /usr/include/net or maybe not installing it at all?
| sys/net/pfvar.h | ||
|---|---|---|
| 602 | You don't need underscores in front of inline for private headers. It is C keyword with modern standards. | |
| sys/net/pfvar.h | ||
|---|---|---|
| 602 | Even if this header is nominally private, some public header might include it, and this bit is not guarded by _KERNEL, I believe. (And there are ioctl definitions in pfvar.h, so how can it be private?) Probably the right thing is to make this function conditional on _KERNEL, if it isn't already. Then yes, the plain inline keyword can be used. | |