Page MenuHomeFreeBSD
Differential D48966

sound: Call chn_kill() in chn_init() failure
ClosedPublic
Actions

Authored by christos on Feb 12 2025, 4:04 PM.
Tags
None
Referenced Files
F140086063: D48966.id150982.diff
Sat, Dec 20, 1:23 AM
Unknown Object (File)
Thu, Dec 18, 11:27 PM
Unknown Object (File)
Thu, Dec 11, 9:48 AM
Unknown Object (File)
Wed, Dec 10, 12:32 PM
Unknown Object (File)
Wed, Dec 10, 12:32 PM
Unknown Object (File)
Sat, Dec 6, 2:44 AM
Unknown Object (File)
Sat, Dec 6, 1:35 AM
Unknown Object (File)
Fri, Nov 28, 12:04 PM
View All 91 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG858504a1d89f: sound: Call chn_kill() in chn_init() failure
rGbc7e65e95015: sound: Call chn_kill() in chn_init() failure
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Feb 12 2025, 4:04 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2025, 4:04 PM
christos requested review of this revision.Feb 12 2025, 4:04 PM
Harbormaster completed remote builds in B62397: Diff 150911.Feb 12 2025, 4:05 PM
christos added a parent revision: D48962: sound: Update comment and channel insertion in vchan_create().Feb 12 2025, 4:06 PM
christos added inline comments.Feb 12 2025, 4:08 PM
sys/dev/sound/pcm/channel.c
1311

I removed this and moved these increments inside the switch at the top of chn_init(). This is to avoid inconsistencies since chn_kill() decrements these counters.

markj added inline comments.Feb 13 2025, 4:49 PM
sys/dev/sound/pcm/channel.c
1181–1183

The FALLTHROUGH comment has to appear at the end of the case.

1185

This comment doesn't seem very useful?

christos marked 2 inline comments as done.Feb 13 2025, 5:01 PM
christos added inline comments.
sys/dev/sound/pcm/channel.c
1185

This was a leftover I forgot to correct. Thank you.

christos marked an inline comment as done.Feb 13 2025, 5:02 PM
christos updated this revision to Diff 150982.Feb 13 2025, 5:02 PM

Address Mark's comments.

Harbormaster completed remote builds in B62426: Diff 150982.Feb 13 2025, 5:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2025, 11:49 AM
Closed by commit rGbc7e65e95015: sound: Call chn_kill() in chn_init() failure (authored by christos). · Explain Why
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGbc7e65e95015: sound: Call chn_kill() in chn_init() failure.
christos added a commit: rG858504a1d89f: sound: Call chn_kill() in chn_init() failure.Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
50 lines

Diff 151470

View Options

sys/dev/sound/pcm/channel.c

Loading...