Page MenuHomeFreeBSD

sound: Call chn_kill() in chn_init() failure
ClosedPublic

Authored by christos on Feb 12 2025, 4:04 PM.
Tags
None
Referenced Files
F133413202: D48966.diff
Sat, Oct 25, 3:11 PM
F133405572: D48966.id150911.diff
Sat, Oct 25, 1:47 PM
Unknown Object (File)
Sun, Oct 12, 3:37 PM
Unknown Object (File)
Fri, Oct 10, 1:26 AM
Unknown Object (File)
Tue, Sep 30, 8:52 AM
Unknown Object (File)
Tue, Sep 30, 12:50 AM
Unknown Object (File)
Sep 25 2025, 12:03 AM
Unknown Object (File)
Sep 17 2025, 5:11 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/sound/pcm/channel.c
1311

I removed this and moved these increments inside the switch at the top of chn_init(). This is to avoid inconsistencies since chn_kill() decrements these counters.

sys/dev/sound/pcm/channel.c
1181–1183

The FALLTHROUGH comment has to appear at the end of the case.

1185

This comment doesn't seem very useful?

christos added inline comments.
sys/dev/sound/pcm/channel.c
1185

This was a leftover I forgot to correct. Thank you.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2025, 11:49 AM
This revision was automatically updated to reflect the committed changes.