Differential D49071

ctld: Fail UCL configurations with a nested error
ClosedPublic
Actions

Authored by jhb on Feb 19 2025, 11:05 PM.

Details

Reviewers

asomers

Commits

rGf3a43b3db881: ctld: Fail UCL configurations with a nested error

Summary

Errors from auth groups, portal groups, global luns, and targets were
not propagated out of the main loop.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62568
Build 59452: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 19 2025, 11:05 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2025, 11:05 PM

jhb requested review of this revision.Feb 19 2025, 11:05 PM

jhb added a parent revision: D48934: ctld: Add a dedicated API between parse.y and the rest of the program.

Harbormaster completed remote builds in B62531: Diff 151225.Feb 19 2025, 11:05 PM

jhb added a child revision: D48935: ctld: Be more consistent for auth parameters in the UCL config.Feb 19 2025, 11:06 PM

Fix a few nits missed in last rebase

Harbormaster completed remote builds in B62568: Diff 151306.Feb 21 2025, 7:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 3:16 PM

Closed by commit rGf3a43b3db881: ctld: Fail UCL configurations with a nested error (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf3a43b3db881: ctld: Fail UCL configurations with a nested error.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

uclparse.c

17 lines

Diff 151306

View Options

ctld: Fail UCL configurations with a nested errorClosedPublicActions