Page MenuHomeFreeBSD
Differential D48935

ctld: Be more consistent for auth parameters in the UCL config
ClosedPublic
Actions

Authored by jhb on Feb 11 2025, 1:20 AM.
Tags
None
Referenced Files
F168839986: D48935.diff
Sun, Aug 30, 9:46 AM
F168754774: D48935.id151499.diff
Sat, Aug 29, 11:48 PM
Unknown Object (File)
Sat, Aug 29, 1:37 PM
Unknown Object (File)
Sat, Aug 29, 12:17 PM
Unknown Object (File)
Thu, Aug 27, 3:05 AM
Unknown Object (File)
Wed, Aug 26, 1:17 PM
Unknown Object (File)
Wed, Aug 26, 4:18 AM
Unknown Object (File)
Tue, Aug 25, 9:52 PM
View All Files
Subscribers
imp

Details

Reviewers
asomers
Commits
rG8824cd3a1170: ctld: Be more consistent for auth parameters in the UCL config
rGe28b758b35d0: ctld: Be more consistent for auth parameters in the UCL config
Summary

The auth-group required an array of entries for "chap", "chap-mutual",
"initiator-name", and "initiator-portal" whereas the target context
required exactly one entry (and only permitted a single entry).

Allow either a single entry or an array of entries for these keywords
in both the auth-group and target contexts.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62362
Build 59246: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 11 2025, 1:20 AM
Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2025, 1:20 AM
jhb requested review of this revision.Feb 11 2025, 1:20 AM
Harbormaster completed remote builds in B62362: Diff 150824.Feb 11 2025, 1:20 AM
jhb added a parent revision: D48934: ctld: Add a dedicated API between parse.y and the rest of the program.Feb 11 2025, 1:20 AM
jhb added a child revision: D48936: ctld: Add missing properties to the UCL parser.
jhb added a parent revision: D49071: ctld: Fail UCL configurations with a nested error.Feb 19 2025, 11:06 PM
jhb removed a parent revision: D48934: ctld: Add a dedicated API between parse.y and the rest of the program.
jhb updated this revision to Diff 151226.Feb 19 2025, 11:07 PM

Rebase after removing globals from parse.y

Harbormaster completed remote builds in B62532: Diff 151226.Feb 19 2025, 11:07 PM
jhb updated this revision to Diff 151307.Feb 21 2025, 7:51 PM

Fix a few nits missed in last rebase

Harbormaster completed remote builds in B62569: Diff 151307.Feb 21 2025, 7:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2025, 3:16 PM
Closed by commit rGe28b758b35d0: ctld: Be more consistent for auth parameters in the UCL config (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGe28b758b35d0: ctld: Be more consistent for auth parameters in the UCL config.
jhb added a commit: rG8824cd3a1170: ctld: Be more consistent for auth parameters in the UCL config.Jan 27 2026, 6:45 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
163 lines

Diff 150824

View Options

usr.sbin/ctld/uclparse.c

Loading...