Page MenuHomeFreeBSD
Differential D48771

ctld: Move kernel_limits into login.c where it is used
ClosedPublic
Actions

Authored by jhb on Jan 31 2025, 8:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 26, 8:10 AM
Unknown Object (File)
Nov 3 2025, 7:45 PM
Unknown Object (File)
Nov 3 2025, 7:42 PM
Unknown Object (File)
Nov 3 2025, 7:41 PM
Unknown Object (File)
Nov 3 2025, 7:41 PM
Unknown Object (File)
Nov 3 2025, 7:40 PM
Unknown Object (File)
Nov 2 2025, 2:41 AM
Unknown Object (File)
Nov 1 2025, 11:53 PM
View All 59 Files
Subscribers
imp

Details

Reviewers
asomers
mav
trasz
Commits
rG9e425a8a7ef0: ctld: Move kernel_limits into login.c where it is used
Summary

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62176
Build 59060: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 31 2025, 8:16 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 31 2025, 8:16 PM
jhb requested review of this revision.Jan 31 2025, 8:16 PM
Harbormaster completed remote builds in B62176: Diff 150292.Jan 31 2025, 8:16 PM
jhb added a parent revision: D48770: ctld: Don't specify the TCP port for default iSCSI portal group sockets.Jan 31 2025, 8:16 PM
jhb added a child revision: D48772: ctld: Add abstractions to support multiple target protocols.
asomers requested changes to this revision.Jan 31 2025, 10:24 PM
asomers added inline comments.
usr.sbin/ctld/ctld.h
50

You can delete this line now.

This revision now requires changes to proceed.Jan 31 2025, 10:24 PM
jhb added inline comments.Jan 31 2025, 11:07 PM
usr.sbin/ctld/ctld.h
50

Oh, yes, I think I currently have that in a later commit and had just missed that when splitting my initial nvme patch up into separate commits.

jhb updated this revision to Diff 150366.Feb 1 2025, 2:18 PM

Remove dup macro and fix compile

Harbormaster completed remote builds in B62205: Diff 150366.Feb 1 2025, 2:18 PM
asomers accepted this revision.Feb 1 2025, 2:24 PM
This revision is now accepted and ready to land.Feb 1 2025, 2:24 PM
Closed by commit rG9e425a8a7ef0: ctld: Move kernel_limits into login.c where it is used (authored by jhb). · Explain WhyFeb 5 2025, 7:56 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG9e425a8a7ef0: ctld: Move kernel_limits into login.c where it is used.

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
5 lines
54 lines
62 lines

Diff 150292

View Options

usr.sbin/ctld/ctld.h

Loading...
View Options

usr.sbin/ctld/kernel.c

Loading...
View Options

usr.sbin/ctld/login.c

Loading...