ctld: Write the pidfile once after forking
ClosedPublic
Actions

Authored by jhb on Jan 31 2025, 8:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 8, 1:13 PM

	Unknown Object (File)
	Mar 19 2025, 6:50 PM

	Unknown Object (File)
	Mar 15 2025, 8:25 AM

	Unknown Object (File)
	Mar 8 2025, 3:03 PM

	Unknown Object (File)
	Mar 1 2025, 1:46 PM

	Unknown Object (File)
	Feb 25 2025, 11:05 PM

	Unknown Object (File)
	Feb 17 2025, 8:03 PM

	Unknown Object (File)
	Feb 12 2025, 2:16 AM

View All 15 Files

Subscribers

imp

Details

Reviewers

asomers
mav
trasz

Commits

rG7bad3c3e5f1c: ctld: Write the pidfile once after forking

Summary

Don't rewrite the pidfile each time main_loop is called.

PR: 284282
Reported by: asomers
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62173
Build 59057: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 31 2025, 8:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 31 2025, 8:16 PM

Harbormaster completed remote builds in B62173: Diff 150289.Jan 31 2025, 8:16 PM

jhb requested review of this revision.Jan 31 2025, 8:16 PM

jhb added a parent revision: D48767: libnvmf: Add nvmf_nqn_valid_strict() function.

jhb added a child revision: D48769: ctld: Refactor out functions to parse dscp and pcp properties.

Thank you!

This revision is now accepted and ready to land.Jan 31 2025, 10:09 PM

Closed by commit rG7bad3c3e5f1c: ctld: Write the pidfile once after forking (authored by jhb). · Explain WhyFeb 5 2025, 7:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7bad3c3e5f1c: ctld: Write the pidfile once after forking.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.c

8 lines

Diff 150289

View Options

ctld: Write the pidfile once after forkingClosedPublicActions