Differential D48703

sockets/tcp: quick fix for regression with SO_REUSEPORT_LB
ClosedPublic
Actions

Authored by glebius on Jan 27 2025, 10:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 7, 2:03 AM

	Unknown Object (File)
	Tue, Apr 7, 1:48 AM

	Unknown Object (File)
	Tue, Apr 7, 1:39 AM

	Unknown Object (File)
	Mon, Apr 6, 8:37 PM

	Unknown Object (File)
	Wed, Apr 1, 8:31 AM

	Unknown Object (File)
	Sun, Mar 22, 12:40 PM

	Unknown Object (File)
	Sun, Mar 22, 1:40 AM

	Unknown Object (File)
	Fri, Mar 20, 1:21 PM

Subscribers

Details

Reviewers

Group Reviewers

network
transport

Commits

rG06bf119f265c: sockets/tcp: quick fix for regression with SO_REUSEPORT_LB

Summary

There was a long living problem that pr_listen is called every time on
consecutive listen(2) syscalls. Up until today it produces spurious TCP
state change events in tracing software and other harmless problems. But
with 7cbb6b6e28db we started to call LIST_REMOVE() twice on the same
entry.

This is quite ugly, but quick and robuse fix against regression, that we
decided to put in the scope of the January stabilization week. A better
refactoring will happen later.

Fixes: 7cbb6b6e28db33095a1cf7a8887921a5ec969824

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62072
Build 58956: arc lint + arc unit

Event Timeline

glebius created this revision.Jan 27 2025, 10:34 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 27 2025, 10:34 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Jan 27 2025, 10:34 PM

Harbormaster completed remote builds in B62072: Diff 150055.Jan 27 2025, 10:34 PM

Of course TCP over IPv6 needs identical hot fix.

Harbormaster completed remote builds in B62073: Diff 150056.Jan 27 2025, 10:57 PM

markj accepted this revision as: markj.Jan 27 2025, 11:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2025, 5:03 AM

Closed by commit rG06bf119f265c: sockets/tcp: quick fix for regression with SO_REUSEPORT_LB (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG06bf119f265c: sockets/tcp: quick fix for regression with SO_REUSEPORT_LB.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

6 lines

Diff 150055

sys/netinet/tcp_usrreq.c

Loading...