Paths

Table of Contentst

cam: Implement ascq ranges correctly
AbandonedPublic
Actions

Authored by imp on Jan 25 2025, 8:10 PM.

Tags

None

Referenced Files

	F174365094: D48686.id.diff
	Fri, Oct 2, 5:20 PM

	Unknown Object (File)
	Wed, Sep 30, 2:48 PM

	Unknown Object (File)
	Mon, Sep 28, 3:18 PM

	Unknown Object (File)
	Thu, Sep 24, 4:20 AM

	Unknown Object (File)
	Sun, Sep 20, 7:38 AM

	Unknown Object (File)
	Sat, Sep 19, 7:07 PM

	Unknown Object (File)
	Fri, Sep 11, 2:32 PM

	Unknown Object (File)
	Sun, Sep 6, 3:24 AM

View All Files

Subscribers

None

Details

Reviewers

mav
chs
ken

Group Reviewers

cam

Summary

Ensure that the range is between the first and second entries. At the
moment, all the SSQ_RANGE entries are tagged with 0xFF, no change is
expeccted.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62029
Build 58913: arc lint + arc unit

Event Timeline

imp created this revision.Jan 25 2025, 8:10 PM

Herald added a reviewer: cam. · View Herald TranscriptJan 25 2025, 8:10 PM

imp requested review of this revision.Jan 25 2025, 8:10 PM

imp added a parent revision: D48685: cam: Fix off by one error in ASC/ASCQ lookup.

Harbormaster completed remote builds in B62029: Diff 149973.Jan 25 2025, 8:10 PM

imp added a child revision: D48687: cam/da: Document what an 'invalid pack' means..Jan 25 2025, 8:10 PM

This change is unneeded. ascq <= table_entry->ascq is already checked few lines above.

This revision now requires changes to proceed.Jan 27 2025, 4:08 PM

Bah! You're right. Punting on this one.

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

scsi_all.c

7 lines

Diff 149973

View Options

cam: Implement ascq ranges correctlyAbandonedPublicActions