Page MenuHomeFreeBSD
Differential D48348

pci_find_cap_method(): limit number of iterations for finding a capability
ClosedPublic
Actions

Authored by kib on Jan 6 2025, 11:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 19, 8:19 PM
Unknown Object (File)
Sat, Sep 19, 8:14 PM
Unknown Object (File)
Sat, Sep 19, 6:08 PM
Unknown Object (File)
Tue, Sep 8, 1:10 PM
Unknown Object (File)
Aug 23 2026, 3:45 PM
Unknown Object (File)
Aug 19 2026, 11:25 PM
Unknown Object (File)
Aug 12 2026, 5:49 PM
Unknown Object (File)
Aug 10 2026, 7:21 AM
View All 92 Files
Subscribers
emaste
imp

Details

Reviewers
imp
Commits
rG6ba2c036a011: pci_find_cap_method(): limit number of iterations for finding a capability
Summary
Powered down device might return 0xff of extended config registers
reads, causing loop.

PR:     283815

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jan 6 2025, 11:32 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 6 2025, 11:32 PM
kib requested review of this revision.Jan 6 2025, 11:32 PM
imp accepted this revision.Jan 6 2025, 11:50 PM

Any chance 0x40 has a constant already defined for it?

This revision is now accepted and ready to land.Jan 6 2025, 11:50 PM
kib added a comment.Jan 7 2025, 12:05 AM
In D48348#1102529, @imp wrote:

Any chance 0x40 has a constant already defined for it?

I tried to explain it in the comment above, your suggestion is welcomed. It should be the size of the fixed PCI header of some type.

emaste added a subscriber: emaste.Jan 7 2025, 3:34 PM
Closed by commit rG6ba2c036a011: pci_find_cap_method(): limit number of iterations for finding a capability (authored by kib). · Explain WhyJan 7 2025, 3:36 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG6ba2c036a011: pci_find_cap_method(): limit number of iterations for finding a capability.

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
7 lines

Diff 148879

View Options

sys/dev/pci/pci.c

Loading...