Page MenuHomeFreeBSD
Differential D48347

ls: --group-directories=first/last
ClosedPublic
Actions

Authored by pstef on Jan 6 2025, 9:30 PM.
Tags
None
Referenced Files
F168375698: D48347.id148857.diff
Thu, Aug 27, 8:43 PM
F168348416: D48347.id149081.diff
Thu, Aug 27, 5:40 PM
F168304582: D48347.id148857.diff
Thu, Aug 27, 1:16 PM
Unknown Object (File)
Sat, Aug 22, 1:09 PM
Unknown Object (File)
Thu, Aug 20, 11:17 AM
Unknown Object (File)
Wed, Aug 12, 11:28 PM
Unknown Object (File)
Wed, Aug 12, 6:51 PM
Unknown Object (File)
Tue, Aug 11, 11:53 PM
View All Files
Subscribers
imp
jhb
ziaee

Details

Reviewers
None
Group Reviewers
srcmgr
manpages
Commits
rG8b92977857f8: ls: implement --group-directories-first for compatibility with GNU ls
Summary

Implement --group-directories-first for compatibility with GNU ls.

Also implement --group-directories which takes a parameter.
"first" is equivalent to --group-directories-first, "last" gives
reversed sorting.

Changes in sorting between elements of the same type (files,
directories) are not intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

pstef created this revision.Jan 6 2025, 9:30 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 6 2025, 9:30 PM
pstef requested review of this revision.Jan 6 2025, 9:30 PM
pstef updated this revision to Diff 148840.Jan 6 2025, 10:01 PM
pstef updated this revision to Diff 148857.Jan 7 2025, 7:00 AM
pstef updated this revision to Diff 148896.Jan 7 2025, 5:37 PM
ziaee added reviewers: srcmgr, manpages.Jan 8 2025, 3:22 AM
ziaee added a subscriber: ziaee.

I do not like long options. We have a different culture and tradition that has a steep learning curve, but has led to the last living usable, daily driveable CLI. Long options are great for scripts but ruin the usability of CLI as a UX. This is just a comment and not a request for changes or nack. Cc'ing community leaders for review, and manpages since this is a manpage change.

pstef added a comment.Jan 8 2025, 6:46 AM

This is for compatibility with GNU ls, where this is an equally long option.
We already distribute a system where ls is an alias.

jhb added a subscriber: jhb.Jan 9 2025, 4:59 PM

Supporting the GNU ls option (--group-directories-first) as a long option seems fine to me. For the FreeBSD-specific extension the similar long option is probably ok. If -G wasn't already claimed by color ls perhaps that would have been a good candidate, but there are very few remaining single-letter options.

bin/ls/ls.1
315 ↗(On Diff #148896)

Does this need a note about not being compatible with POSIX? I note that --color is missing such a note but other single-letter extensions are annotated as such both in the option description and in the STANDARDS section.

pstef added inline comments.Jan 10 2025, 6:28 PM
bin/ls/ls.1
315 ↗(On Diff #148896)

I don't have a good idea how to craft the words here.

pstef updated this revision to Diff 149081.Jan 10 2025, 6:28 PM

Try to address comments from jhb.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2025, 4:04 PM
Closed by commit rG8b92977857f8: ls: implement --group-directories-first for compatibility with GNU ls (authored by pstef). · Explain Why
This revision was automatically updated to reflect the committed changes.
pstef added a commit: rG8b92977857f8: ls: implement --group-directories-first for compatibility with GNU ls.

Revision Contents
Changeset List

PathSize
bin/
ls/
35 lines
4 lines

Diff 148840

View Options

bin/ls/ls.c

Loading...
View Options

bin/ls/util.c

Loading...