Page MenuHomeFreeBSD
Differential D48286

arm64: Add a new SOC_ROCKCHIP option
ClosedPublic
Actions

Authored by manu on Jan 2 2025, 12:52 PM.
Tags
None
Referenced Files
F168026967: D48286.diff
Wed, Aug 26, 12:18 AM
F167983332: D48286.id148670.diff
Tue, Aug 25, 6:16 PM
Unknown Object (File)
Mon, Aug 24, 5:39 PM
Unknown Object (File)
Thu, Aug 20, 8:30 AM
Unknown Object (File)
Tue, Aug 18, 9:32 PM
Unknown Object (File)
Tue, Aug 18, 10:55 AM
Unknown Object (File)
Tue, Aug 18, 7:13 AM
Unknown Object (File)
Mon, Aug 17, 3:24 AM
View All 96 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
Group Reviewers
arm64
Commits
rG48db612d8939: arm64: Add a new SOC_ROCKCHIP option
Summary

A lot of drivers are shared between all rockchip SoCs, each time we add
suppot for a new SoC we need to add the options in the files.arm64 lines.
Add a new option SOC_ROCKCHIP that will help simplify this file.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61456
Build 58340: arc lint + arc unit

Event Timeline

manu created this revision.Jan 2 2025, 12:52 PM
Herald added a reviewer: andrew. · View Herald TranscriptJan 2 2025, 12:52 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: andrew. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
manu requested review of this revision.Jan 2 2025, 12:52 PM
Harbormaster completed remote builds in B61456: Diff 148670.Jan 2 2025, 12:52 PM
manu added a reviewer: arm64.Jan 2 2025, 12:54 PM
andrew added a comment.Jan 2 2025, 4:07 PM

Can you add a comment that SOC_ROCKCHIP_* depend on SOC_ROCKCHIP

andrew accepted this revision.Jan 2 2025, 4:07 PM
This revision is now accepted and ready to land.Jan 2 2025, 4:07 PM
manu added a comment.Jan 2 2025, 7:33 PM
In D48286#1101250, @andrew wrote:

Can you add a comment that SOC_ROCKCHIP_* depend on SOC_ROCKCHIP

Sure, where do you think it would be best, in options.arm64 ?

andrew added a comment.Jan 3 2025, 1:45 PM

Yes, that's probably the best place for it

Closed by commit rG48db612d8939: arm64: Add a new SOC_ROCKCHIP option (authored by manu). · Explain WhyJan 6 2025, 7:40 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG48db612d8939: arm64: Add a new SOC_ROCKCHIP option.

Revision Contents
Changeset List

PathSize
sys/
arm64/
conf/
1 line
conf/
30 lines
1 line

Diff 148670

View Options

sys/arm64/conf/std.rockchip

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/conf/options.arm64

Loading...