Differential D48236

tcp: properly reset sackhint values when SACK recovery is done
ClosedPublic
Actions

Authored by glebius on Dec 29 2024, 12:26 AM.

Tags

None

Referenced Files

	F171081760: D48236.id149198.diff
	Tue, Sep 8, 2:28 PM

	Unknown Object (File)
	Tue, Sep 8, 1:52 AM

	Unknown Object (File)
	Mon, Sep 7, 11:59 PM

	Unknown Object (File)
	Sat, Sep 5, 2:38 PM

	Unknown Object (File)
	Sat, Sep 5, 1:49 PM

	Unknown Object (File)
	Sat, Sep 5, 12:01 PM

	Unknown Object (File)
	Sat, Sep 5, 3:47 AM

	Unknown Object (File)
	Fri, Sep 4, 3:47 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGb84f41b4e82d: tcp: properly reset sackhint values when SACK recovery is done

Summary

When the SACK scoreboard collapses, properly clear all the counters.
The counters are used in tcp_compute_pipe(), which can be called
anytime later after the SACK recovery. The returned result can be
totally bogus, including both too large and too small values.

PR: 283649

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61376
Build 58260: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 29 2024, 12:26 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 29 2024, 12:26 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Dec 29 2024, 12:26 AM

Harbormaster completed remote builds in B61376: Diff 148501.Dec 29 2024, 12:26 AM

glebius added a parent revision: D48235: tcp: make sack_rxmit in tcp_output() a bool.Dec 29 2024, 12:26 AM

glebius added a child revision: D48237: tcp: don't send beyond receivers advertised window.

emaste added a subscriber: emaste.Jan 13 2025, 1:04 AM

rscheff accepted this revision.Jan 13 2025, 10:20 AM

This revision is now accepted and ready to land.Jan 13 2025, 10:20 AM

Closed by commit rGb84f41b4e82d: tcp: properly reset sackhint values when SACK recovery is done (authored by glebius). · Explain WhyJan 13 2025, 6:15 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGb84f41b4e82d: tcp: properly reset sackhint values when SACK recovery is done.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

27 lines

Diff 148501

sys/netinet/tcp_sack.c

Loading...