Page MenuHomeFreeBSD
Differential D48156

sound: Do not return an error from chn_notify() if the children list is empty
AcceptedPublic
Actions

Authored by christos on Dec 19 2024, 11:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 9:58 AM
Unknown Object (File)
Tue, Jan 14, 9:32 PM
Unknown Object (File)
Sat, Jan 11, 10:51 PM
Unknown Object (File)
Wed, Jan 8, 8:54 PM
Unknown Object (File)
Wed, Jan 8, 4:04 AM
Unknown Object (File)
Fri, Dec 27, 11:28 PM
Unknown Object (File)
Thu, Dec 26, 4:10 PM
Unknown Object (File)
Thu, Dec 26, 12:27 PM
View All 11 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Summary

An empty children list does not mean that there is an error.

Reported by: Florian Walpen <dev@submerge.ch>
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61274
Build 58158: arc lint + arc unit

Event Timeline

christos created this revision.Dec 19 2024, 11:20 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2024, 11:20 PM
christos requested review of this revision.Dec 19 2024, 11:20 PM
Harbormaster completed remote builds in B61274: Diff 148266.Dec 19 2024, 11:20 PM
christos mentioned this in D47917: sound: Allocate vchans on-demand.Dec 19 2024, 11:20 PM
christos added a child revision: D47917: sound: Allocate vchans on-demand.Dec 19 2024, 11:23 PM
dev_submerge.ch accepted this revision.Tue, Dec 24, 12:38 PM

I can confirm that this fixes the panic experienced with D47917, and I don't see anything else that could be affected by the change in return value. Thank you!

This revision is now accepted and ready to land.Tue, Dec 24, 12:38 PM
christos added a comment.Tue, Dec 24, 5:20 PM
In D48156#1098827, @dev_submerge.ch wrote:

I can confirm that this fixes the panic experienced with D47917, and I don't see anything else that could be affected by the change in return value. Thank you!

Thank you for proposing this. :-)

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
2 lines

Diff 148266

View Options

sys/dev/sound/pcm/channel.c

Loading...