Page MenuHomeFreeBSD

Add libpkgecc/libder
AbandonedPublic

Authored by kevans on Dec 16 2024, 4:24 AM.
Tags
None
Referenced Files
F167746508: D48104.id148006.diff
Mon, Aug 24, 5:58 AM
F167740596: D48104.largetrue.diff
Mon, Aug 24, 4:56 AM
F167739660: D48104.id.diff
Mon, Aug 24, 4:42 AM
F167722757: D48104.diff
Mon, Aug 24, 12:48 AM
F167686661: D48104.id.largetrue.diff
Sun, Aug 23, 6:55 PM
F167686124: D48104.id.diff
Sun, Aug 23, 6:51 PM
F167683767: D48104.largetrue.diff
Sun, Aug 23, 6:25 PM
F167680025: D48104.diff
Sun, Aug 23, 5:53 PM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61193
Build 58077: arc lint + arc unit

Event Timeline

Sorry, crap description that won't be used as-is. libecc and libder will be used for forthcoming ECC support in pkg(7).

This revision is now accepted and ready to land.Dec 16 2024, 1:49 PM

I assume libder and libecc are unmodified? I'd suggest doing the vendor imports and then updating this review which would then be just a merge + addition of build bits. Overall looks fine to me.

secure/lib/libpkgecc/Makefile
2

I might explain this in more detail and I think it's fine to be prescriptive e.g. "this is not a general purpose library and is for use only by pkg(7)"

Replaced with separated imports/build bits.