Page MenuHomeFreeBSD

Add libpkgecc/libder
AbandonedPublic

Authored by kevans on Dec 16 2024, 4:24 AM.
Tags
None
Referenced Files
F162761826: D48104.id.largetrue.diff
Thu, Jul 16, 2:28 PM
Unknown Object (File)
Wed, Jul 15, 11:30 PM
Unknown Object (File)
Wed, Jul 15, 5:47 PM
Unknown Object (File)
Wed, Jul 15, 1:35 PM
Unknown Object (File)
Tue, Jul 14, 9:11 AM
Unknown Object (File)
Tue, Jul 7, 12:12 AM
Unknown Object (File)
Sun, Jul 5, 4:20 PM
Unknown Object (File)
Sun, Jul 5, 4:19 PM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61193
Build 58077: arc lint + arc unit

Event Timeline

Sorry, crap description that won't be used as-is. libecc and libder will be used for forthcoming ECC support in pkg(7).

This revision is now accepted and ready to land.Dec 16 2024, 1:49 PM

I assume libder and libecc are unmodified? I'd suggest doing the vendor imports and then updating this review which would then be just a merge + addition of build bits. Overall looks fine to me.

secure/lib/libpkgecc/Makefile
2

I might explain this in more detail and I think it's fine to be prescriptive e.g. "this is not a general purpose library and is for use only by pkg(7)"

Replaced with separated imports/build bits.