Page MenuHomeFreeBSD

Add libpkgecc/libder
AbandonedPublic

Authored by kevans on Mon, Dec 16, 4:24 AM.
Tags
None
Referenced Files
F106371685: D48104.diff
Sun, Dec 29, 1:38 PM
Unknown Object (File)
Sat, Dec 28, 2:43 PM
Unknown Object (File)
Sat, Dec 28, 1:41 PM
Unknown Object (File)
Fri, Dec 27, 8:27 AM
Unknown Object (File)
Mon, Dec 23, 4:41 PM
Unknown Object (File)
Thu, Dec 19, 6:22 PM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61193
Build 58077: arc lint + arc unit

Event Timeline

Sorry, crap description that won't be used as-is. libecc and libder will be used for forthcoming ECC support in pkg(7).

This revision is now accepted and ready to land.Mon, Dec 16, 1:49 PM

I assume libder and libecc are unmodified? I'd suggest doing the vendor imports and then updating this review which would then be just a merge + addition of build bits. Overall looks fine to me.

secure/lib/libpkgecc/Makefile
2

I might explain this in more detail and I think it's fine to be prescriptive e.g. "this is not a general purpose library and is for use only by pkg(7)"

Replaced with separated imports/build bits.