Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 61193 Build 58077: arc lint + arc unit
Event Timeline
Comment Actions
Sorry, crap description that won't be used as-is. libecc and libder will be used for forthcoming ECC support in pkg(7).
Comment Actions
I assume libder and libecc are unmodified? I'd suggest doing the vendor imports and then updating this review which would then be just a merge + addition of build bits. Overall looks fine to me.
secure/lib/libpkgecc/Makefile | ||
---|---|---|
2 | I might explain this in more detail and I think it's fine to be prescriptive e.g. "this is not a general purpose library and is for use only by pkg(7)" |