sound: Get rid of redundant variables in chn_setspeed() and chn_setformat()
ClosedPublic
Actions

Authored by christos on Dec 9 2024, 10:57 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG9091f61d2f2c: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat()
rG4e1b75bebf41: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat()

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61059
Build 57943: arc lint + arc unit

Event Timeline

christos created this revision.Dec 9 2024, 10:57 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2024, 10:57 PM

Harbormaster completed remote builds in B61059: Diff 147757.Dec 9 2024, 10:57 PM

christos requested review of this revision.Dec 9 2024, 10:57 PM

christos added a child revision: D48012: sound: Return if the new speed/format is the same as the current one.Dec 9 2024, 10:58 PM

dev_submerge.ch accepted this revision.Dec 13 2024, 12:51 AM

This revision is now accepted and ready to land.Dec 13 2024, 12:51 AM

Yeah, this is a small reduction in confusion

Closed by commit rG4e1b75bebf41: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat() (authored by christos). · Explain WhyFeb 25 2025, 11:48 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG4e1b75bebf41: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat().

christos added a commit: rG9091f61d2f2c: sound: Get rid of redundant variables in chn_setspeed() and chn_setformat().Mar 4 2025, 3:47 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.c

12 lines

Diff 147757

View Options

sys/dev/sound/pcm/channel.c

sound: Get rid of redundant variables in chn_setspeed() and chn_setformat()ClosedPublicActions