Page MenuHomeFreeBSD
Differential D47676

new-bus: Deprecate bus_generic_(attach|probe)
ClosedPublic
Actions

Authored by jhb on Nov 19 2024, 3:32 PM.
Tags
None
Referenced Files
F166637533: D47676.diff
Sat, Aug 15, 2:35 AM
Unknown Object (File)
Thu, Aug 13, 9:04 PM
Unknown Object (File)
Thu, Aug 13, 2:36 PM
Unknown Object (File)
Wed, Aug 12, 3:25 PM
Unknown Object (File)
Wed, Aug 12, 8:40 AM
Unknown Object (File)
Wed, Aug 12, 12:04 AM
Unknown Object (File)
Tue, Aug 11, 8:17 PM
Unknown Object (File)
Tue, Aug 11, 8:17 PM
View All Files
Subscribers
None

Details

Reviewers
imp
Commits
rGa553e07c4ddc: new-bus: Deprecate bus_generic_(attach|probe)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60689
Build 57573: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 19 2024, 3:32 PM
jhb created this revision.
jhb added a parent revision: D47675: Replace calls to bus_generic_attach with bus_attach_children.
jhb added a child revision: D47677: bus_delayed_attach_children: Switch return type to void.
Harbormaster completed remote builds in B60689: Diff 146703.Nov 19 2024, 3:32 PM
jhb added inline comments.Nov 19 2024, 3:33 PM
sys/sys/bus.h
446

This predates the addition of __deprecated in <sys/cdefs.h>, but I also want to use a message here which doesn't work with the variant in <sys/cdefs.h>.

imp added inline comments.Nov 21 2024, 10:36 PM
sys/sys/bus.h
446

Maybe we need __deprecated2 that uses this form?

jhb added inline comments.Nov 22 2024, 2:45 PM
sys/sys/bus.h
446

Or perhaps __deprecated1 since it takes one argument (so same naming scheme as accept4, pipe2, etc.)?

jhb updated this revision to Diff 146839.Nov 22 2024, 3:35 PM

Use __deprecated1

Harbormaster completed remote builds in B60728: Diff 146839.Nov 22 2024, 3:35 PM
imp accepted this revision.Nov 22 2024, 8:17 PM
This revision is now accepted and ready to land.Nov 22 2024, 8:17 PM
Closed by commit rGa553e07c4ddc: new-bus: Deprecate bus_generic_(attach|probe) (authored by jhb). · Explain WhyDec 6 2024, 10:29 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa553e07c4ddc: new-bus: Deprecate bus_generic_(attach|probe).

Revision Contents
Changeset List

PathSize
sys/
sys/
6 lines

Diff 146703

View Options

sys/sys/bus.h

Loading...