Page MenuHomeFreeBSD
Differential D5742

Remove old depend code and make FAST_DEPEND one true way.
ClosedPublic
Actions

Authored by bdrewery on Mar 25 2016, 9:56 PM.
Tags
None
Referenced Files
F106638566: D5742.diff
Fri, Jan 3, 4:21 AM
Unknown Object (File)
Mon, Dec 16, 11:46 PM
Unknown Object (File)
Wed, Dec 11, 5:11 PM
Unknown Object (File)
Mon, Dec 9, 11:00 PM
Unknown Object (File)
Thu, Dec 5, 11:26 PM
Unknown Object (File)
Thu, Dec 5, 11:26 PM
Unknown Object (File)
Thu, Dec 5, 11:26 PM
Unknown Object (File)
Thu, Dec 5, 11:26 PM
View All Files
Subscribers
wblock

Details

Reviewers
brooks
emaste
jhb
• hselasky
imp
Group Reviewers
manpages
Commits
rS297434: Remove the old depend (mkdep) code and make FAST_DEPEND the one true way.
Summary

All of the removed code is handled by the FAST_DEPEND code.

A suspicious looking removals are in bsd.prog.mk/bsd.lib.mk but they were
replaced by a OBJS_DEPEND_GUESS variable that bsd.dep.mk now handles
when there is no .depend.<foo.o> file.

I am unsure if I missed more in sys/conf that can come out.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3009
Build 3039: arc lint + arc unit

Event Timeline

bdrewery updated this revision to Diff 14614.Mar 25 2016, 9:56 PM
bdrewery retitled this revision from to Remove old depend code and make FAST_DEPEND one true way..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added reviewers: imp, emaste, • hselasky, jhb.
bdrewery updated this revision to Diff 14616.Mar 25 2016, 9:59 PM

Fix a comment and remove more from sys/conf.

bdrewery added a reviewer: brooks.Mar 25 2016, 11:08 PM
emaste added inline comments.Mar 29 2016, 5:49 PM
Makefile.inc1
151–155

This is now redundant.

bdrewery added inline comments.Mar 29 2016, 5:49 PM
Makefile.inc1
151–155

Ah right, I intended to remove all of the 'make depend' in here too. Thanks.

bdrewery updated this revision to Diff 14720.Mar 29 2016, 6:01 PM

Remove leftover tree-walks and NO_KERNELDEPEND references. Also fixup build.7 documentation for new depend.

Herald added a reviewer: manpages. · View Herald TranscriptMar 29 2016, 6:01 PM
emaste added inline comments.Mar 29 2016, 6:07 PM
Makefile.inc1
646

This will break some of my finger memory :-)

• hselasky accepted this revision.Mar 29 2016, 6:11 PM
• hselasky edited edge metadata.

Looks OK with regard to the kern.post.mk mlx5 related changes.

This revision is now accepted and ready to land.Mar 29 2016, 6:11 PM
bdrewery updated this revision to Diff 14721.Mar 29 2016, 7:06 PM
bdrewery edited edge metadata.

Keep old stage numbers

This revision now requires review to proceed.Mar 29 2016, 7:06 PM
Herald edited edge metadata. · View Herald TranscriptMar 29 2016, 7:06 PM
emaste added inline comments.Mar 29 2016, 7:14 PM
Makefile.inc1
646

Although I do have searched build logs with /4\.4/, the comment was mostly in jest. Having a missing 4.3 is probably more confusing.

bdrewery updated this revision to Diff 14722.Mar 29 2016, 7:16 PM
bdrewery edited edge metadata.

Don't skip stage numbers

Herald edited edge metadata. · View Herald TranscriptMar 29 2016, 7:16 PM
emaste accepted this revision.Mar 29 2016, 7:19 PM
emaste edited edge metadata.

I think this is fine. This stuff is subtle and I'm a bit worried about edge cases, but I don't see a good way to find them other than committing.

This revision is now accepted and ready to land.Mar 29 2016, 7:19 PM
wblock added a subscriber: wblock.Mar 29 2016, 9:12 PM
wblock added inline comments.
Makefile.inc1
987

A word is missing (probably "on"), but "depending" is likely not the best choice of word here, either. The wording is so vague it is hard to suggest something clearer. Something about how TARGET affects which config files are used, at a guess.

share/man/man7/build.7
128 ↗(On Diff #14722)

Quotes are not needed here. They are only necessary when single parameter will be mistaken to be multiples because of whitespace. No harm, though.

sys/conf/kern.post.mk
151

spelling error

emaste added inline comments.Mar 29 2016, 9:22 PM
Makefile.inc1
987

Indeed, but this predates @bdrewery's changes by a decade and a half or so. This should be improved in a separate commit.

sys/conf/kern.post.mk
151

As above, perhaps in a separate commit

brooks accepted this revision.Mar 30 2016, 5:54 PM
brooks edited edge metadata.

No obvious issues in the diff. I've been running our local tree with FAST_DEPEND as the default for quite a while now and haven't had any issues.

bdrewery updated this revision to Diff 14751.Mar 30 2016, 9:38 PM
bdrewery edited edge metadata.

A few more unneeded 'make depend' walks

This revision now requires review to proceed.Mar 30 2016, 9:38 PM
Herald edited edge metadata. · View Herald TranscriptMar 30 2016, 9:38 PM
Closed by commit rS297434: Remove the old depend (mkdep) code and make FAST_DEPEND the one true way. (authored by bdrewery). · Explain WhyMar 30 2016, 11:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
9 lines
gnu/
lib/
csu/
1 line
share/
mk/
5 lines
57 lines
23 lines
7 lines
7 lines
1 line
sys/
conf/
7 lines
46 lines
23 lines
5 lines
modules/
pflog/
5 lines
pfsync/
5 lines
wtap/
5 lines
tools/
build/
options/

Diff 14614

View Options

Makefile.inc1

Loading...
View Options

gnu/lib/csu/Makefile

Loading...
View Options

share/mk/bsd.clang-analyze.mk

Loading...
View Options

share/mk/bsd.dep.mk

Loading...
View Options

share/mk/bsd.lib.mk

Loading...
View Options

share/mk/bsd.opts.mk

Loading...
View Options

share/mk/bsd.prog.mk

Loading...
View Options

share/mk/local.meta.sys.mk

Loading...
View Options

sys/conf/kern.opts.mk

Loading...
View Options

sys/conf/kern.post.mk

Loading...
View Options

sys/conf/kern.pre.mk

Loading...
View Options

sys/conf/kmod.mk

Loading...
View Options

sys/modules/pflog/Makefile

Loading...
View Options

sys/modules/pfsync/Makefile

Loading...
View Options

sys/modules/wtap/Makefile

Loading...
View Options

tools/build/options/WITHOUT_FAST_DEPEND

Loading...
View Options

tools/build/options/WITH_FAST_DEPEND

Loading...