Page MenuHomeFreeBSD
Differential D47403

loader: Fix boot menu on BIOS
ClosedPublic
Actions

Authored by imp on Nov 2 2024, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 11:35 AM
Unknown Object (File)
Mar 17 2025, 10:10 PM
Unknown Object (File)
Mar 11 2025, 6:35 PM
Unknown Object (File)
Mar 11 2025, 2:56 AM
Unknown Object (File)
Mar 6 2025, 3:50 PM
Unknown Object (File)
Mar 4 2025, 7:31 AM
Unknown Object (File)
Mar 1 2025, 1:20 PM
Unknown Object (File)
Feb 16 2025, 4:21 PM
View All 61 Files
Subscribers
dab
dhw
emaste
zarychtam_plan-b.pwste.edu.pl

Details

Reviewers
manu
cperciva
kevans
Commits
rG0d2b7892cd3a: loader: Fix boot menu on BIOS
rGf2103edaf522: loader: Fix boot menu on BIOS
rGc2ba66d4d01f: loader: Fix boot menu on BIOS
Summary

Only the gfx-enabled boot loader supports unicode. Otherwise, we have to
use the old cons25 / ibmpc upper code page drawing characters. Check to
see if we have the gfx.term_drawbox function. If we do, we support the
unicode drawing characters. If we don't, then we have an older loader
that doesn't support it *OR* we have the reduced function, text-only
boot loader. Either way, we need to use the old graphics characters.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60350
Build 57234: arc lint + arc unit

Event Timeline

imp created this revision.Nov 2 2024, 4:33 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 2 2024, 4:33 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Nov 2 2024, 4:33 PM
Harbormaster completed remote builds in B60345: Diff 145890.Nov 2 2024, 4:33 PM
imp added reviewers: cperciva, kevans.Nov 2 2024, 4:35 PM
dhw added a subscriber: dhw.Nov 2 2024, 5:04 PM

Tested successfully on a laptop: first, running stable/14-n269448-4e8444d5750a, then running main-n273387-bb8b3b174118.

imp updated this revision to Diff 145892.Nov 2 2024, 6:46 PM

Update to move these knowledge into core.hasUnicode() in case
other issues like this crop up, or in case we export this knowledge
more directly.

Harbormaster completed remote builds in B60347: Diff 145892.Nov 2 2024, 6:46 PM
imp updated this revision to Diff 145893.Nov 2 2024, 6:51 PM

better comment
also remove comment from where we create old bindings:
with this new setup they aren't relevant.

Harbormaster completed remote builds in B60348: Diff 145893.Nov 2 2024, 6:51 PM
emaste added a subscriber: emaste.Nov 2 2024, 9:04 PM
emaste added inline comments.
stand/lua/core.lua
548
imp updated this revision to Diff 145907.Nov 2 2024, 10:02 PM

fix ed's typo

Harbormaster completed remote builds in B60350: Diff 145907.Nov 2 2024, 10:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 2 2024, 10:03 PM
Closed by commit rGc2ba66d4d01f: loader: Fix boot menu on BIOS (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGc2ba66d4d01f: loader: Fix boot menu on BIOS.
zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.EditedNov 2 2024, 10:12 PM

Thank you for coming up with the solution. I can confirm that it fixes the issue for sc(4). Please don't hesitate to push it, preferably shortly.
Edit:
Wow.... already committed. Impressive timings!

imp added a commit: rGf2103edaf522: loader: Fix boot menu on BIOS.Nov 4 2024, 4:58 AM
imp added a commit: rG0d2b7892cd3a: loader: Fix boot menu on BIOS.Nov 7 2024, 12:51 AM

Revision Contents
Changeset List

PathSize
stand/
lua/
9 lines
32 lines

Diff 145907

View Options

stand/lua/core.lua

.\" $FreeBSD$ .\" $FreeBSD$
Set to not build and install the enhanced Install the traditional FreeBSD
.Xr bc 1 .Xr bc 1
jhbUnsubmitted
Not Done
Inline Actions

I would maybe avoid making other changes for this commit than just the "Set to" part. Losing the Xr sections for bc and dc seems rather odd.

Granted, I would rewrite this description to be something like "Use the traditional FreeBSD versions of bc(1) and dc(1) rather than the <foo> versions." where <foo> is more descriptive than just "enhanced".

jhb: I would maybe avoid making other changes for this commit than just the "Set to" part. Losing…
emasteAuthorUnsubmitted
Done
Inline Actions

Huh, I think this must have been an accident during a rebase, I did not intend to drop these. When I first did this it was a bit of sed with manual review/touch-ups. In can incorporate feedback before this gets committed and/or we can make further improvements like this one after commit.

I am also not sure what <foo> would be off hand.

emaste: Huh, I think this must have been an accident during a rebase, I did not intend to drop these.
and and
.Xr dc 1 .Xr dc 1
programs instead of the traditional FreeBSD versions. programs instead of the enahnced versions.
emasteAuthorUnsubmitted
Done
Inline Actions

and of course I have a typo here. corrected locally.

emaste: and of course I have a typo here. corrected locally.
View Options

stand/lua/drawer.lua

.\" $FreeBSD$ .\" $FreeBSD$
Set to not build and install the enhanced Install the traditional FreeBSD
.Xr bc 1 .Xr bc 1
jhbUnsubmitted
Not Done
Inline Actions

I would maybe avoid making other changes for this commit than just the "Set to" part. Losing the Xr sections for bc and dc seems rather odd.

Granted, I would rewrite this description to be something like "Use the traditional FreeBSD versions of bc(1) and dc(1) rather than the <foo> versions." where <foo> is more descriptive than just "enhanced".

jhb: I would maybe avoid making other changes for this commit than just the "Set to" part. Losing…
emasteAuthorUnsubmitted
Done
Inline Actions

Huh, I think this must have been an accident during a rebase, I did not intend to drop these. When I first did this it was a bit of sed with manual review/touch-ups. In can incorporate feedback before this gets committed and/or we can make further improvements like this one after commit.

I am also not sure what <foo> would be off hand.

emaste: Huh, I think this must have been an accident during a rebase, I did not intend to drop these.
and and
.Xr dc 1 .Xr dc 1
programs instead of the traditional FreeBSD versions. programs instead of the enahnced versions.
emasteAuthorUnsubmitted
Done
Inline Actions

and of course I have a typo here. corrected locally.

emaste: and of course I have a typo here. corrected locally.