Page MenuHomeFreeBSD
Differential D47403

loader: Fix boot menu on BIOS
ClosedPublic
Actions

Authored by imp on Sat, Nov 2, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 2:59 PM
Unknown Object (File)
Thu, Nov 21, 1:33 PM
Unknown Object (File)
Thu, Nov 21, 4:12 AM
Unknown Object (File)
Fri, Nov 15, 8:40 AM
Unknown Object (File)
Fri, Nov 15, 12:07 AM
Unknown Object (File)
Sun, Nov 10, 8:46 PM
Unknown Object (File)
Thu, Nov 7, 5:40 AM
Unknown Object (File)
Thu, Nov 7, 5:35 AM
View All 27 Files
Subscribers
dab
dhw
emaste
zarychtam_plan-b.pwste.edu.pl

Details

Reviewers
manu
cperciva
kevans
Commits
rG0d2b7892cd3a: loader: Fix boot menu on BIOS
rGf2103edaf522: loader: Fix boot menu on BIOS
rGc2ba66d4d01f: loader: Fix boot menu on BIOS
Summary

Only the gfx-enabled boot loader supports unicode. Otherwise, we have to
use the old cons25 / ibmpc upper code page drawing characters. Check to
see if we have the gfx.term_drawbox function. If we do, we support the
unicode drawing characters. If we don't, then we have an older loader
that doesn't support it *OR* we have the reduced function, text-only
boot loader. Either way, we need to use the old graphics characters.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60345
Build 57229: arc lint + arc unit

Event Timeline

imp created this revision.Sat, Nov 2, 4:33 PM
Herald added a reviewer: manu. · View Herald TranscriptSat, Nov 2, 4:33 PM
Herald added a subscriber: dab. · View Herald Transcript
imp requested review of this revision.Sat, Nov 2, 4:33 PM
Harbormaster completed remote builds in B60345: Diff 145890.Sat, Nov 2, 4:33 PM
imp added reviewers: cperciva, kevans.Sat, Nov 2, 4:35 PM
dhw added a subscriber: dhw.Sat, Nov 2, 5:04 PM

Tested successfully on a laptop: first, running stable/14-n269448-4e8444d5750a, then running main-n273387-bb8b3b174118.

imp updated this revision to Diff 145892.Sat, Nov 2, 6:46 PM

Update to move these knowledge into core.hasUnicode() in case
other issues like this crop up, or in case we export this knowledge
more directly.

Harbormaster completed remote builds in B60347: Diff 145892.Sat, Nov 2, 6:46 PM
imp updated this revision to Diff 145893.Sat, Nov 2, 6:51 PM

better comment
also remove comment from where we create old bindings:
with this new setup they aren't relevant.

Harbormaster completed remote builds in B60348: Diff 145893.Sat, Nov 2, 6:51 PM
emaste added a subscriber: emaste.Sat, Nov 2, 9:04 PM
emaste added inline comments.
stand/lua/core.lua
548 ↗(On Diff #145893)
imp updated this revision to Diff 145907.Sat, Nov 2, 10:02 PM

fix ed's typo

Harbormaster completed remote builds in B60350: Diff 145907.Sat, Nov 2, 10:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Nov 2, 10:03 PM
Closed by commit rGc2ba66d4d01f: loader: Fix boot menu on BIOS (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGc2ba66d4d01f: loader: Fix boot menu on BIOS.
zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.EditedSat, Nov 2, 10:12 PM

Thank you for coming up with the solution. I can confirm that it fixes the issue for sc(4). Please don't hesitate to push it, preferably shortly.
Edit:
Wow.... already committed. Impressive timings!

imp added a commit: rGf2103edaf522: loader: Fix boot menu on BIOS.Mon, Nov 4, 4:58 AM
imp added a commit: rG0d2b7892cd3a: loader: Fix boot menu on BIOS.Thu, Nov 7, 12:51 AM

Revision Contents
Changeset List

PathSize
stand/
liblua/
4 lines
lua/
40 lines

Diff 145890

View Options

stand/liblua/gfx_utils.c

Loading...
View Options

stand/lua/drawer.lua

Loading...