Page MenuHomeFreeBSD
Differential D40477

HWT: ARM CoreSight support
Needs ReviewPublic
Actions

Authored by br on Jun 9 2023, 3:06 PM.
Tags
None
Referenced Files
F108023307: D40477.id124428.diff
Mon, Jan 20, 3:37 PM
Unknown Object (File)
Sat, Jan 18, 9:30 PM
Unknown Object (File)
Sat, Jan 18, 5:57 PM
Unknown Object (File)
Sat, Jan 18, 5:56 PM
Unknown Object (File)
Sat, Jan 18, 5:55 PM
Unknown Object (File)
Sat, Jan 18, 4:33 AM
Unknown Object (File)
Fri, Jan 17, 2:37 AM
Unknown Object (File)
Wed, Jan 15, 7:26 PM
View All Files
Subscribers
andrew
emaste
zachary.leaf_arm.com

Details

Reviewers
andrew
manu
zachary.leaf_arm.com
Summary
  • Add ARM Coresight (SoC-400) support to HWT framework
  • Pipeline build code added
Test Plan

Tested on ARM Morello platform.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br created this revision.Jun 9 2023, 3:06 PM
Herald added a reviewer: manu. · View Herald TranscriptJun 9 2023, 3:06 PM
Herald added subscribers: emaste, andrew. · View Herald Transcript
br requested review of this revision.Jun 9 2023, 3:06 PM
br updated this revision to Diff 123011.Jun 9 2023, 3:08 PM

Add CORESIGHT_DEBUG macro.

br added a parent revision: D40466: Hardware Trace (HWT) framework.Jun 9 2023, 3:09 PM
br updated this revision to Diff 123013.Jun 9 2023, 3:14 PM

Wrap long lines.

br updated this revision to Diff 123014.Jun 9 2023, 3:15 PM

Fix comment.

zachary.leaf_arm.com added a subscriber: zachary.leaf_arm.com.Jun 12 2023, 10:43 AM
br updated this revision to Diff 123109.Jun 12 2023, 2:59 PM

Provide the name of backend needed for registration in HWT framework.

br updated this revision to Diff 123515.Jun 20 2023, 2:11 PM

clean up

Herald added a reviewer: andrew. · View Herald TranscriptJun 20 2023, 2:11 PM
Herald added a reviewer: andrew. · View Herald Transcript
br updated this revision to Diff 123667.Jun 23 2023, 8:26 AM

Interface to HWT changed

br updated this revision to Diff 123690.Jun 23 2023, 6:50 PM

morello-dts included for test

Herald added 1 blocking reviewer(s): manu. · View Herald TranscriptJun 23 2023, 6:50 PM
br added a child revision: D40728: hwt(8) utility added.Jun 23 2023, 6:57 PM
br updated this revision to Diff 123721.Jun 24 2023, 11:29 AM

Regenerate

br updated this revision to Diff 123892.Jun 28 2023, 10:35 AM

Make coresight optional. Depends on hwt

br updated this revision to Diff 124189.Jul 5 2023, 10:57 AM

coresight_setup() method added

br updated this revision to Diff 124428.Jul 10 2023, 12:14 PM

regenerate

br updated this revision to Diff 124537.Jul 12 2023, 1:18 PM

hwt_backend interface changed

br updated this revision to Diff 124864.Jul 19 2023, 3:20 PM

Kernel-mode tracing support added.

br updated this revision to Diff 125099.Jul 24 2023, 9:43 PM

allow tracing multiple cpus in system mode

br updated this revision to Diff 125192.Jul 26 2023, 2:47 PM

Regenerate

br updated this revision to Diff 125347.Jul 30 2023, 10:15 PM

ability to build as a module

br updated this revision to Diff 125359.Jul 31 2023, 11:50 AM

Fix tracing cpu_id > 0

br updated this revision to Diff 125527.Aug 3 2023, 6:12 PM

regenerate

br updated this revision to Diff 125697.Aug 8 2023, 12:36 PM

regenerate

br updated this revision to Diff 126229.Aug 19 2023, 1:13 PM

Regenerate

zachary.leaf_arm.com added inline comments.Sep 18 2023, 11:57 AM
sys/arm64/coresight/coresight.c
72

Should we dynamically allocate this based on mp_ncpus instead, especially since MAXCPU is being bumped to 1024? I think it would make sense to do that in coresight_backend_init and then can free() at the end of coresight_backend_deinit.

This is what I'm doing for SPE at the moment.

br updated this revision to Diff 127774.Sep 25 2023, 2:11 PM

rebase for freebsd

br updated this revision to Diff 127816.Sep 26 2023, 10:31 AM
br removed a reviewer: manu.

Pass ctx to backend_deinit().

Herald added a reviewer: manu. · View Herald TranscriptSep 26 2023, 10:31 AM
andrew added a comment.Sep 26 2023, 2:06 PM

This doesn't build when I add hwt and coresight to my kernel config

mhorne mentioned this in D35709: fix pmcstat .Oct 10 2023, 5:24 PM
br updated this revision to Diff 135750.Mar 14 2024, 3:55 PM

Regen

zachary.leaf_arm.com added a reviewer: zachary.leaf_arm.com.Mar 14 2024, 5:25 PM
br updated this revision to Diff 141895.Aug 7 2024, 3:01 PM

Regen

br edited the test plan for this revision. (Show Details)Aug 7 2024, 3:02 PM
br updated this revision to Diff 145558.Oct 28 2024, 7:17 PM

Regenerate

br updated this revision to Diff 149258.Tue, Jan 14, 8:22 PM

Due to pipeline design Coresight components could not be used for more than 1 concurrent tracing sessions.
Atomic counter of sessions added and limited to 1.

br added a comment.Tue, Jan 14, 8:24 PM
In D40477#957268, @andrew wrote:

This doesn't build when I add hwt and coresight to my kernel config

Could you try again? A change in modules/Makefile was missing

br edited the summary of this revision. (Show Details)Tue, Jan 14, 8:25 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
coresight/
60 lines
339 lines
168 lines
39 lines
67 lines
199 lines
6 lines
27 lines
64 lines
5 lines
33 lines
6 lines
29 lines
47 lines
5 lines
35 lines
6 lines
27 lines
14 lines
662 lines
6 lines
42 lines
modules/
coresight/
11 lines
coresight/
14 lines
cpu_debug/
8 lines
etm4x/
8 lines
funnel/
8 lines
replicator/
8 lines
tmc/
8 lines

Diff 145558

View Options

sys/arm64/coresight/coresight.h

Loading...
View Options

sys/arm64/coresight/coresight.c

Loading...
View Options

sys/arm64/coresight/coresight_cmd.c

Loading...
View Options

sys/arm64/coresight/coresight_cpu_debug.c

Loading...
View Options

sys/arm64/coresight/coresight_etm4x.h

Loading...
View Options

sys/arm64/coresight/coresight_etm4x.c

Loading...
View Options

sys/arm64/coresight/coresight_etm4x_acpi.c

Loading...
View Options

sys/arm64/coresight/coresight_etm4x_fdt.c

Loading...
View Options

sys/arm64/coresight/coresight_fdt.c

Loading...
View Options

sys/arm64/coresight/coresight_funnel.h

Loading...
View Options

sys/arm64/coresight/coresight_funnel.c

Loading...
View Options

sys/arm64/coresight/coresight_funnel_acpi.c

Loading...
View Options

sys/arm64/coresight/coresight_funnel_fdt.c

Loading...
View Options

sys/arm64/coresight/coresight_if.m

Loading...
View Options

sys/arm64/coresight/coresight_replicator.h

Loading...
View Options

sys/arm64/coresight/coresight_replicator.c

Loading...
View Options

sys/arm64/coresight/coresight_replicator_acpi.c

Loading...
View Options

sys/arm64/coresight/coresight_replicator_fdt.c

Loading...
View Options

sys/arm64/coresight/coresight_tmc.h

Loading...
View Options

sys/arm64/coresight/coresight_tmc.c

Loading...
View Options

sys/arm64/coresight/coresight_tmc_acpi.c

Loading...
View Options

sys/arm64/coresight/coresight_tmc_fdt.c

Loading...
View Options

sys/modules/coresight/Makefile

Loading...
View Options

sys/modules/coresight/coresight/Makefile

Loading...
View Options

sys/modules/coresight/cpu_debug/Makefile

Loading...
View Options

sys/modules/coresight/etm4x/Makefile

Loading...
View Options

sys/modules/coresight/funnel/Makefile

Loading...
View Options

sys/modules/coresight/replicator/Makefile

Loading...
View Options

sys/modules/coresight/tmc/Makefile

Loading...