Page MenuHomeFreeBSD

lib/geom: remove redundant libraries and objects
ClosedPublic

Authored by fuz on Oct 11 2024, 2:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 8:09 PM
Unknown Object (File)
Fri, Nov 29, 8:19 AM
Unknown Object (File)
Nov 23 2024, 1:35 PM
Unknown Object (File)
Nov 14 2024, 1:21 PM
Unknown Object (File)
Oct 31 2024, 7:25 PM
Unknown Object (File)
Oct 25 2024, 7:42 PM
Unknown Object (File)
Oct 20 2024, 10:45 PM
Unknown Object (File)
Oct 20 2024, 10:45 PM
Subscribers

Details

Summary

Do not link lib/geom/raid with libmd, it is not required for the module.
Do not include the sha256/sha512 code in lib/geom/eli, it is provided by
libmd. Remove ${.CURDIR:H:H}/misc from .PATH for all modules. This
path has stopped being valid when the GEOM modules were moved from
sbin/geom to lib/geom.

Test Plan

no functional changes, builds fine.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59906
Build 56791: arc lint + arc unit

Event Timeline

fuz requested review of this revision.Oct 11 2024, 2:58 PM
emaste added inline comments.
lib/geom/eli/Makefile
9–10

This appeared in 7a3f5d11fb3873674a1f7e27bcc9a5f7ce279390, replacing SRCS+= sha2.c. That came from c58794debd2bf. libmd was added in fd833a6a190f8 without removing sha2.c. So it looks to me like this just fell through the cracks.

lib/geom/raid/Makefile
6

This was added at the beginning of geom/raid in 89b172238a5db, MFgraid/head.

This revision is now accepted and ready to land.Oct 11 2024, 3:12 PM