LinuxKPI: always include linux/kconfig.h
ClosedPublic
Actions

Authored by bz on Sep 26 2024, 11:50 PM.

Details

Reviewers

imp
emaste

Group Reviewers

linuxkpi

Commits

rG20fe7e889f3f: LinuxKPI: always include linux/kconfig.h
rG41283b454b7a: LinuxKPI: always include linux/kconfig.h

Summary

Always include linux/kconfig.h which seems to match Linux behaviour
and avoid errors compiling code expected from that file but never
included.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 59610
Build 56497: arc lint + arc unit

Event Timeline

bz created this revision.Sep 26 2024, 11:50 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 26 2024, 11:50 PM

bz requested review of this revision.Sep 26 2024, 11:50 PM

Harbormaster completed remote builds in B59610: Diff 143769.Sep 26 2024, 11:50 PM

anyone? x11 maybe for drm-kmod?

Yes it looks like Linux's Makefile forces -include of both compiler-version.h and kconfig.h.

Seems sane

This revision is now accepted and ready to land.Oct 11 2024, 2:35 PM

emaste accepted this revision.Oct 11 2024, 2:42 PM

Closed by commit rG41283b454b7a: LinuxKPI: always include linux/kconfig.h (authored by bz). · Explain WhyOct 11 2024, 8:51 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG41283b454b7a: LinuxKPI: always include linux/kconfig.h.

bz added a commit: rG20fe7e889f3f: LinuxKPI: always include linux/kconfig.h.Oct 17 2024, 9:18 AM

Revision Contents
Changeset List

Path

Size

sys/

conf/

kern.pre.mk

3 lines

kmod.mk

3 lines

Diff 143769

View Options

sys/conf/kern.pre.mk