Page MenuHomeFreeBSD
Differential D46785

netinet*: Add assertions for some places that don't support M_EXTPG mbufs
ClosedPublic
Actions

Authored by jhb on Sep 25 2024, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 6:16 AM
Unknown Object (File)
Tue, Aug 11, 8:27 PM
Unknown Object (File)
Mon, Aug 10, 7:56 AM
Unknown Object (File)
Sun, Aug 9, 1:30 PM
Unknown Object (File)
Fri, Aug 7, 5:34 PM
Unknown Object (File)
Wed, Aug 5, 3:21 AM
Unknown Object (File)
Tue, Aug 4, 7:48 AM
Unknown Object (File)
Mon, Aug 3, 9:16 AM
View All Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
gallatin
kp
Commits
rG28aafeb83c08: netinet*: Add assertions for some places that don't support M_EXTPG mbufs
Summary

Found while auditing calls to M_WRITABLE to see if M_EXTPG could be
removed from its checks.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59595
Build 56482: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 25 2024, 3:13 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptSep 25 2024, 3:13 PM
jhb requested review of this revision.Sep 25 2024, 3:13 PM
Harbormaster completed remote builds in B59595: Diff 143716.Sep 25 2024, 3:13 PM
jhb added a parent revision: D46784: ktls: Mark mbufs containing outbound encrypted TLS records read-only.Sep 25 2024, 3:13 PM
jhb added a child revision: D46786: m_unshare: Fail with a NULL return if the chain contains unmapped mbufs.
kp added inline comments.Sep 26 2024, 8:15 AM
sys/netinet6/ip6_mroute.c
1533

I'm not sure we need this here. I don't see anything that assumes we're mapped.

jhb added inline comments.Sep 27 2024, 9:41 PM
sys/netinet6/ip6_mroute.c
1543

m_pullup() assumes mapped mbufs, and m_copym() will preserve unmapped mbufs in the new chain

jhb added a comment.Oct 15 2024, 3:54 PM

Ping

gallatin accepted this revision.Oct 15 2024, 5:10 PM
This revision is now accepted and ready to land.Oct 15 2024, 5:10 PM
Closed by commit rG28aafeb83c08: netinet*: Add assertions for some places that don't support M_EXTPG mbufs (authored by jhb). · Explain WhyOct 31 2024, 8:34 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG28aafeb83c08: netinet*: Add assertions for some places that don't support M_EXTPG mbufs.

Revision Contents
Changeset List

PathSize
sys/
netinet/
1 line
4 lines
2 lines
netinet6/
5 lines

Diff 143716

View Options

sys/netinet/igmp.c

Loading...
View Options

sys/netinet/ip_mroute.c

Loading...
View Options

sys/netinet/ip_options.c

Loading...
View Options

sys/netinet6/ip6_mroute.c

Loading...